Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 388012 - Use Cairo instead of gdk_gc_set_clip_region() in Theme
Summary: Use Cairo instead of gdk_gc_set_clip_region() in Theme
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-08-24 12:53 EDT by Anatoly Spektor CLA
Modified: 2013-07-18 06:41 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-08-24 12:53:54 EDT 
This patch uses Cairo instead of deprecated gdk_gc_set_clip_region() in Theme and makes function dynamic:


http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk_gc_clip_region
Comment 1 Arun Thondapu CLA 2012-08-31 10:14:43 EDT 
I think there is a mistake in the Cairo portion of the code in this patch.
The clip region setting should be done for curGC[0] and not for data.cairo which is a different Cairo graphics context.

Using curGC[0] directly as a Cairo context (int /*long*/ cairo = curGC) might work but I can't be completely sure without testing it.
Comment 2 Anatoly Spektor CLA 2012-08-31 10:57:53 EDT 
I see where you are coming from, and I think it makes sense, I am just not sure if cairo methods will accept curGC as  "cairo" context, but it is very possible that it could work out.

The big question here is how to test it, I tried several ways to get to transferClipping, but none of them seems to give any results.

On the other hand, we should come up with decision regarding this issue, as without resolving it we won't compile against GTK+ 3.

Regards,

Anatoly
Comment 3 Alexander Kurtakov CLA 2013-07-13 04:01:15 EDT 
I think we can close this now as Theme is pretty much dead and it would need way bigger intervention than that to become usable.
Comment 4 Alexander Kurtakov CLA 2013-07-18 06:41:46 EDT 
Closing. Please reopen when/if one decides to work on Theme.