Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 387920 - Sentence fragments in org.eclipse.orion.client.git\web\git\nls\root\gitmessages.js
Summary: Sentence fragments in org.eclipse.orion.client.git\web\git\nls\root\gitmessag...
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.0 M2   Edit
Assignee: Edyta Przymus CLA
QA Contact:
URL:
Whiteboard: gsoc2012
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 13:51 EDT by Kit Lo CLA
Modified: 2012-09-03 09:57 EDT (History)
4 users (show)

See Also:

Attachments
New wording for Review Request Dialog (7.87 KB, image/png)
2012-08-28 07:49 EDT, Edyta Przymus CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kit Lo CLA 2012-08-23 13:51:01 EDT 
I saw two new strings in: org.eclipse.orion.client.git\web\git\nls\root\gitmessages.js
  "Contribution Review Request" : "Contribution Review Request",
  "or sent the link to the reviewer" : "or sent the link to the reviewer"

Don't know if they are sentence fragments broken into 2 strings. Anyway, the string "or sent the link to the reviewer" by itself without context cannot be properly translated in many languages. And, if you just join this string to another string to build another sentence, it may not work in many languages.
Comment 1 Szymon Brandys CLA 2012-08-28 07:39:47 EDT 
Edyta, please take a look.
Comment 2 Edyta Przymus CLA 2012-08-28 07:49:46 EDT 
Created attachment 220379 [details]
New wording for Review Request Dialog
Comment 3 Edyta Przymus CLA 2012-08-28 07:55:15 EDT 
http://127.0.0.2:8080/git/reviewRequest.html#git@github.com:edytaprzymus/orion.client.git_530d0296a65f4827620ba1dde01f47e393821eb6

I changed wording so it looks like on screenshot. I think it's also fine.
Comment 5 Kit Lo CLA 2012-09-01 11:31:25 EDT 
Is the change delivered yet?
Comment 6 Szymon Brandys CLA 2012-09-03 09:57:33 EDT 
(In reply to comment #5)
> Is the change delivered yet?
It is. Marking fixed.