Community
Participate
Working Groups
Second part of bug 359952 solution. Based on bug 387094 fix, we would like to enhance the usability of this feature. New components which will be added: 1. Store one private key per repository. 2. Add a checkbox in the git credentials dialog which would enable the storage mechanism. 3. Allow enabling/disabling storage mechanism via user preferences in the settings section. 4. Add a 'Clear credentials' option in the settings section. 5. Add private key import/export options in the user settings section.
(In reply to comment #0) > 5. Add private key import/export options in the user settings section. No import/export is really necessary. Instead, we allow enabling/disabling prompting providing a checkbox for each repository in the user profile.
Experimental fix: https://github.com/maciej-bendkowski/orion.client/commit/2ea70c19096c053bf156059a60447fbc12b6cb8d Private key and the passphrase are stored in the local storage. For now, in a persistent manner. Each repository may hold an information whether to prompt for credentials or not (besides a global switch). This can be controlled in the git credentials dialog and in the user settings in the user profile category. At the moment this version in quite experimental, so any suggestions on workflow, view, etc. are most welcome.
*** Bug 387094 has been marked as a duplicate of this bug. ***
Comments for get credentials dialog 1) "Don't prompt me again" should be visible only if 'Git Credentials" are enabled 2) I would put "Don't prompt me again" at the bottom of the dialog (between the content and OK button) 3) Credentials are saved only if I use "Browse...", if Put them in the text area they are not saved 4) Since "Don't prompt me again" applies only to private key, maybe it should be disabled if "Ssh password" is selected Comments for changes in "User Profile" 1) I would move "Git Credentials" to its own section 2) "Clear Git Credentials" would be a section action then
Fix: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_111ec9eca991c6efbf0a3da7f263638dd9a3236e
Fixed problem with the Fetch command: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_d74f9cc64c4fa12ef463dd53a8de5322119f137a
Fixed problem with Known Hosts and Push Force: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_33765f458508e8f0ad1ebf5b999bd605be42d48f
The fix merged to master.
