Community
Participate
Working Groups
I recently got an email with review request that works really cool. The only problem I had was that the requester have been using a SSH URL to the repository. I am also using ssh url for my repository, but our URLs differ with the user name, therefore the remote URL could not be matched, I also couldn't re-clone the URL I got, becuase I would have to use the requester credentials. I had to edit the URL I got in mail and only then I could do the review. It would be nice if the review page could match the remote regardless the user name in the URL.
Hello Małgorzata, could you please provide me example of these URLs? Because as I understand this issue, the both URLs you mentioned are URLs to different repositories (your own and requester's) and the commit that should be review doesn't exist in your own repository. So you have to fetch from requester in this case. Or do I understand this issue wrong?
I got review request from Ken, this is an URL: https://orion.eclipse.org/git/pullRequest.html#ssh://kwalker@git.eclipse.org/gitroot/orion/org.eclipse.orion.server.git_b2ba7b1fd083376d3286943b4b4b92ae23afab99 The commit exists in my repo, I performed fetch. The problem is my repo is ssh://mtomczyk@git.eclipse.org/gitroot/orion/org.eclipse.orion.server.git so I had to change the URL to: https://orion.eclipse.org/git/pullRequest.html#ssh://mtomczyk@git.eclipse.org/gitroot/orion/org.eclipse.orion.server.git_b2ba7b1fd083376d3286943b4b4b92ae23afab99 URL kwalker@git.eclipse.org/gitroot/orion/org.eclipse.orion.server.git was not matched with ssh://mtomczyk@git.eclipse.org/gitroot/orion/org.eclipse.orion.server.git. I've been proposed to clone ssh://kwalker@git.eclipse.org/gitroot/orion/org.eclipse.orion.server.git, but I couldn't because I would have to know Ken's password.
Ok, I see this issue. I have to discuss it with Szymon, but my first and probably the simplest idea is to introduce additional section "similar review requests", where links to the repositories with only user's name changed will be listed. You can simply click it and new Review Request will be open.
Created attachment 220153 [details] New section in Review Request page
https://github.com/edytaprzymus/orion.client/commit/cd7e4a72fd3f50a21aee955acc34b57397d4313f This is my solution. Please try it and let me know if it's works as expected.
https://github.com/edytaprzymus/orion.client/commit/bb967cfdb3fd0e23cf05910bfba216456d191899
https://github.com/edytaprzymus/orion.client/commit/98667efa9596f060a5bc6d7ae77eb935a81bdeb6
Looks ok. You could use dojo url object instead of parsing urls manually. See http://dojotoolkit.org/reference-guide/1.7/dojo/Url.html.
