This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 387606 - A contribution to the toolbar without a given id lets Eclipse hang
Summary: A contribution to the toolbar without a given id lets Eclipse hang
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.2.2   Edit
Assignee: Paul Elder CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-20 09:20 EDT by Udo Walker CLA
Modified: 2013-01-29 10:36 EST (History)
1 user (show)

See Also:


Attachments
Stack trace (115.14 KB, text/plain)
2012-08-20 09:20 EDT, Udo Walker CLA
no flags Details
Proposed Fix (4.85 KB, patch)
2013-01-10 14:51 EST, Paul Elder CLA
no flags Details | Diff
mylyn/context/zip (26.17 KB, application/octet-stream)
2013-01-10 14:51 EST, Paul Elder CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Udo Walker CLA 2012-08-20 09:20:46 EDT
Created attachment 220045 [details]
Stack trace

I accidentally added a menu contribution to the toolbar without giving an id like this:

<extension point="org.eclipse.ui.menus">
  <menuContribution allPopups="false"

            locationURI="toolbar:">

     <command commandId="some.command.id" style="push"/>
  </menuContribution>
</extension>

This is the result in the runtime Eclipse 4.2:
The previously opened editors are shown but without content. 
The menu bar is totally missing. Eclipse is not useable anymore.


The stack trace is attached.
Comment 1 Eric Moffatt CLA 2012-09-25 15:22:54 EDT
Udo, thanks for the good pickup.

Most likely the fix would be to check first, log an error and proceed...
Comment 2 Paul Elder CLA 2013-01-10 14:51:20 EST
Created attachment 225472 [details]
Proposed Fix
Comment 3 Paul Elder CLA 2013-01-10 14:51:21 EST
Created attachment 225473 [details]
mylyn/context/zip
Comment 5 Paul Elder CLA 2013-01-17 13:56:08 EST
Verified in 4.2.2 (M20130116-1800)
Comment 6 Paul Elder CLA 2013-01-29 10:36:37 EST
Verified in 4.3-I20130128-2000