Community
Participate
Working Groups
- We were talking about different look of progress indicator, maybe the one we use in "select remote to push" dialog. - There should be more space between the item label and the indicator - We also wanted to use the same indicator for section progress and item progress
Created attachment 219747 [details] Loading char preview The loadingAnimation.gif image from Dojo toolkit looks really awful as a progress indicator in this place. The attachment shows the experiment results.
Proposal: https://github.com/maciej-bendkowski/orion.client/commit/1e83b272c12e96265aa427614f60c7d3af2452c5 With this commit I tried to adopt the "three dots" section look as a progress indicator. Now it should be more consistent with the other indicators. It would be nice to pull the fix into M1.
I also think the proposed animation doesn't look good and the pattern with 3 dots looks much better. If we prefer we can create a custom animation. However I think we should use the same progress indicator in the section and in the other places, so please implement those changes also to the section.js. Please try to use unique css classes and try to avoid custom style in places that may be reused.
(In reply to comment #3) > I also think the proposed animation doesn't look good and the pattern with 3 > dots looks much better. If we prefer we can create a custom animation. I would just raise a separate bug for Anton to add the section-item progress indicator to the icon pass.
I like this approach a lot. It's simple and not intrusive. However I know Szymon is not a found of it, so I'll hold off with committing until he makes the review.
As Szymon requested: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_1e83b272c12e96265aa427614f60c7d3af2452c5
Merged. Thanks Maciek.
