Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 386890 - Need a way to better hide translated plugin (and service) properties from clients
Summary: Need a way to better hide translated plugin (and service) properties from cli...
Status: RESOLVED WONTFIX
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 5.0 M1   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 382396 387399
  Show dependency tree
 
Reported: 2012-08-08 17:00 EDT by Susan McCourt CLA
Modified: 2015-05-05 16:20 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-08-08 17:00:00 EDT
In bug 386509, the "Places" list broke because we use service metadata property "Name" to show the name of the file system.  But when the plugin got internationalized, "Name" got replaced with "NameKey".  (I wondered why the breadcrumb got it right...it was because "fileClient" initializes all of its cached names by reading the catalog.)

But several things seem wrong here:
- Are we saying that for every translatable plugin property there are two possible metadata keys?...  "{PropertyName}" and "{PropertyName}Key"?
- And that every metadata consumer has to now check the property and then check for the NLS property as well?
- how is a particular service consumer to know which properties will/should be translated over time?

It seems that instead, we should change ServiceReference.getProperty to be the one that would know whether a property is translated or not.  A related issue is that we've said "service metadata is fast" and encouraged use of service properties, and now service metadata is asynchronous and possibly slow.

If we can't bury this knowledge in ServiceReference, then we need "rules of engagement" for API clients - how they use service metadata properties and how in the world they would know whether any particular property might be translated.
Comment 1 Susan McCourt CLA 2012-08-08 17:01:29 EDT
Assigning to Simon and marking 1.0 because this affects how plugins define their metadata. It's an API issue and we need to have a story that won't break plugins down the road.
Comment 2 Simon Kaegi CLA 2012-10-15 10:13:39 EDT
I've run out of runway for 1.0 and that means that service metadata i18n will be 2.0.
Comment 3 John Arthorne CLA 2015-05-05 16:20:41 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html