Community
Participate
Working Groups
CBI is pulling in 18 extra bundles that do not exist in the upstream platform build. We need to understand why these bundles are being pulled in by CBI. javax.annotation.source javax.inject.source org.apache.batik.css.source org.apache.batik.util.gui.source org.apache.batik.util.source org.eclipse.core.net.linux.x86_64.source org.eclipse.rcp.configuration.feature.jar org.eclipse.sdk.epp org.eclipse.sdk.epp.executable.gtk.linux.x86_64 org.eclipse.sdk.epp.executable.gtk.linux.x86_64.eclipse org.w3c.css.sac.source org.w3c.dom.smil.source org.w3c.dom.svg.source toolingorg.eclipse.sdk.epp.application toolingorg.eclipse.sdk.epp.config.gtk.linux.x86_64 toolingorg.eclipse.sdk.epp.configuration toolingorg.eclipse.sdk.epp.executable.gtk.linux.x86_64 toolingorg.eclipse.sdk.epp.ini.gtk.linux.x86_64
I think the *.source items can be cleaned up by excluding the plugin id's with the tycho-source-feature-plugin. I was able to clean up the org.apache.batik.*.source items using the following addition to the pom of org.eclipse.e4.rcp. <plugin> <groupId>org.eclipse.tycho.extras</groupId> <artifactId>tycho-source-feature-plugin</artifactId> <executions> <execution> <phase>package</phase> <id>source-feature</id> <goals> <goal>source-feature</goal> </goals> <configuration> <excludes> <plugin id="org.apache.batik.css" /> <plugin id="org.apache.batik.util" /> <plugin id="org.apache.batik.util.gui" /> </excludes> </configuration> </execution> </executions> </plugin> I will try to come up with a patch that will clean up all the *.source items in the list.
I cleaned up the *.source files using the following commits in CBI platform R4. R4 eclipse.platform.releng: http://git.eclipse.org/c/cbi/eclipse.platform.releng.git/commit/?h=Juno_RC4_R4&id=b6091ea4c4849a7812de654a04c41b566769b6cc R4 eclipse.platform.ui: http://git.eclipse.org/c/cbi/eclipse.platform.ui.git/commit/?h=Juno_RC4_R4&id=af30b74c9ee6aabeee2b33e1837a3f7989cf797f The updated list of extra bundles pulled in to CBI platform R4 is as follows: org.eclipse.rcp.configuration.feature.jar org.eclipse.sdk.epp org.eclipse.sdk.epp.executable.gtk.linux.x86_64 org.eclipse.sdk.epp.executable.gtk.linux.x86_64.eclipse toolingorg.eclipse.sdk.epp.application toolingorg.eclipse.sdk.epp.config.gtk.linux.x86_64 toolingorg.eclipse.sdk.epp.configuration toolingorg.eclipse.sdk.epp.executable.gtk.linux.x86_64 toolingorg.eclipse.sdk.epp.ini.gtk.linux.x86_64
While you have "gotten rid of" the problematic .source bundles, my guess is this is probably an oversite in our PDE based build. I've opened bug 387052 to track. I know of no reason we would not want to include the .source bundles for these javax.annotation.source javax.inject.source org.apache.batik.css.source org.apache.batik.util.gui.source org.apache.batik.util.source org.w3c.css.sac.source org.w3c.dom.smil.source org.w3c.dom.svg.source
(In reply to comment #2) > > The updated list of extra bundles pulled in to CBI platform R4 is as follows: > > org.eclipse.rcp.configuration.feature.jar > org.eclipse.sdk.epp > org.eclipse.sdk.epp.executable.gtk.linux.x86_64 > org.eclipse.sdk.epp.executable.gtk.linux.x86_64.eclipse > toolingorg.eclipse.sdk.epp.application > toolingorg.eclipse.sdk.epp.config.gtk.linux.x86_64 > toolingorg.eclipse.sdk.epp.configuration > toolingorg.eclipse.sdk.epp.executable.gtk.linux.x86_64 > toolingorg.eclipse.sdk.epp.ini.gtk.linux.x86_64 The "eclipse.sdk.epp" ones strike me as very "foreign". There's nothing in our Platform repositories that would have these. Nothing in Orbit. Where else do you "get bundles" from? There might be some indirect connection via /releases/juno or something ... but, still not sure what would cause them to be "pulled in". AFAIK
(In reply to comment #4) > (In reply to comment #2) > > > > > The updated list of extra bundles pulled in to CBI platform R4 is as follows: > > > > org.eclipse.rcp.configuration.feature.jar > > org.eclipse.sdk.epp > > org.eclipse.sdk.epp.executable.gtk.linux.x86_64 > > org.eclipse.sdk.epp.executable.gtk.linux.x86_64.eclipse > > toolingorg.eclipse.sdk.epp.application > > toolingorg.eclipse.sdk.epp.config.gtk.linux.x86_64 > > toolingorg.eclipse.sdk.epp.configuration > > toolingorg.eclipse.sdk.epp.executable.gtk.linux.x86_64 > > toolingorg.eclipse.sdk.epp.ini.gtk.linux.x86_64 > > The "eclipse.sdk.epp" ones strike me as very "foreign". There's nothing in > our Platform repositories that would have these. Nothing in Orbit. Where > else do you "get bundles" from? There might be some indirect connection via > /releases/juno or something ... but, still not sure what would cause them to > be "pulled in". > > AFAIK I think this is caused by a uid field we added in the CBI platform build [1]. As I understand it Tycho needs a uid field specified in order to build. I think the fix in this case is likely to rename the uid field to match the id field which is org.eclipse.sdk.ide. The pom file also needs to be updated with the matching uid [2]. [1] http://git.eclipse.org/c/cbi/eclipse.platform.releng.eclipsebuilder.git/diff/eclipse/buildConfigs/sdk/builder/sdk.product?h=Juno_RC4_R4&id=2ccda0c85b90a90c6eb03c5896bfe185a06bff3b [2] http://git.eclipse.org/c/cbi/eclipse.platform.releng.eclipsebuilder.git/diff/eclipse/buildConfigs/sdk/builder/pom.xml?h=Juno_RC4_R4&id=2ccda0c85b90a90c6eb03c5896bfe185a06bff3b
I pushed a patch into CBI platform repos which changes the uid from org.eclipse.sdk.epp to org.eclipse.sdk.ide. eclipse.platform.releng.eclipsebuilder: http://git.eclipse.org/c/cbi/eclipse.platform.releng.eclipsebuilder.git/commit/?h=Juno_RC4_R4&id=f1bd3119f28b31c85ea2cf314b4ab260c6834dbd
(In reply to comment #6) > I pushed a patch into CBI platform repos which changes the uid from > org.eclipse.sdk.epp to org.eclipse.sdk.ide. > > eclipse.platform.releng.eclipsebuilder: > http://git.eclipse.org/c/cbi/eclipse.platform.releng.eclipsebuilder.git/ > commit/?h=Juno_RC4_R4&id=f1bd3119f28b31c85ea2cf314b4ab260c6834dbd Looks like the patch cleaned up some of the extra bundles being pulled in by CBI platform build. An updated list of extra bundles being pulled in by CBI below shows we're only pulling in 5 extra bundles now. org.eclipse.rcp.configuration.feature.jar org.eclipse.sdk.ide.executable.gtk.linux.x86_64 org.eclipse.sdk.ide.executable.gtk.linux.x86_64.eclipse toolingorg.eclipse.sdk.ide.application toolingorg.eclipse.sdk.ide.executable.gtk.linux.x86_64
Considering that the Platform project is releasing CBI builds now I think this issue can be closed.
