Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 386884 - Missing bundles from CBI
Summary: Missing bundles from CBI
Status: RESOLVED FIXED
Alias: None
Product: CBI
Classification: Technology
Component: prototype (show other bugs)
Version: 1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: CBI Dummy user CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 389902 389903 389983 390855 390856
Blocks: 377190
  Show dependency tree
 
Reported: 2012-08-08 15:29 EDT by Thanh Ha CLA
Modified: 2013-12-19 16:03 EST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thanh Ha CLA 2012-08-08 15:29:39 EDT
Today CBI is still missing 15 bundles when compared to the upstream platform build of Juno. We need to understand where these bundles are coming from and how to get them into the CBI build.

javax.el.source
org.eclipse.cvs.source
org.eclipse.equinox.launcher.source
org.eclipse.jdt.source
org.eclipse.pde.source
org.eclipse.rcp.source
org.eclipse.rcp_root
org.eclipse.jdt.doc.isv
org.eclipse.platform.doc.isv
org.eclipse.rcp.configuration_root.gtk.linux.x86_64
org.eclipse.sdk.ide
toolingorg.eclipse.configuration
toolingorg.eclipse.sdk.ide.config.gtk.linux.x86_64
toolingorg.eclipse.sdk.ide.configuration
toolingorg.eclipse.sdk.ide.ini.gtk.linux.x86_64
Comment 1 Thanh Ha CLA 2012-08-08 15:34:22 EDT
I believe the items below come from the generated features in build.properties from org.eclipse.sdk feature.

org.eclipse.cvs.source
org.eclipse.jdt.source
org.eclipse.pde.source
org.eclipse.rcp.source 

There is discussion on this on the mailing list:
  http://dev.eclipse.org/mhonarc/lists/cbi-dev/msg00595.html


Regarding org.eclipse.jdt.doc.isv and org.eclipse.platform.doc.isv I think is being worked on in Bug 385410:
  https://bugs.eclipse.org/bugs/show_bug.cgi?id=385410
Comment 2 David Williams CLA 2012-08-10 21:06:30 EDT
javax.el.source 
This comes from Orbit, ultimately. It is pointed to by our map files and then 
it is included in two "source features" via build.properties: 

org.eclipse.help.source

In .../eclipse.platform.releng/features/org.eclipse.sdk/build.properties

The help.source feature is generated via

generate.feature@org.eclipse.help.source=...javax.el.source...

It is also in the feature

org.eclipse.equinox.source

Which (also) is auto generated by a "generate.feature" directive, this time in 

.../eclipse.platform.releng/features/master-equinox/build.properties

I doubt that is all that helpful ... but, in case it is. 

I actually think this sort of issue is the one (partially, or indirectly) referred to in the msg thread you quote: 
  http://dev.eclipse.org/mhonarc/lists/cbi-dev/msg00595.html
Comment 3 David Williams CLA 2012-08-10 21:12:10 EDT
(In reply to comment #1)
> I believe the items below come from the generated features in
> build.properties from org.eclipse.sdk feature.
> 
> org.eclipse.cvs.source
> org.eclipse.jdt.source
> org.eclipse.pde.source
> org.eclipse.rcp.source 
> 
> There is discussion on this on the mailing list:
>   http://dev.eclipse.org/mhonarc/lists/cbi-dev/msg00595.html
> 
> 

I don't think this is the right reference or thread these these 4 bundles. 

I think these are cases where we (in Platform PDE build) should NOT be generating these .source bundles because in fact there is no Java in them. (I could be wrong, so don't quote me :) 
I think I've seen this discussed somewhere (a bug or cbi list) but do not recall where. 

The org.eclipse.equinox.launcher.source might be similar (no Java files) but just going by its name, I didn't check it.
Comment 4 David Williams CLA 2012-08-10 21:15:50 EDT
(In reply to comment #0)

> org.eclipse.sdk.ide

This I think is the "branding bundle" for the Eclipse SDK "product". 

In our Platform PDE build, we end up with two "products", one for "Platform" (only) and one for "Eclipse SDK". 

I'm probably stating the obvious, but in case that gives you a hint. 

(Can Tycho build two "products" in same run? I have a vague memory of some build system that could only do one at a time ... but ... very vague and probably something else not Tycho ... just thought I'd ask).
Comment 5 Thanh Ha CLA 2012-08-13 11:56:53 EDT
(In reply to comment #4)
> (In reply to comment #0)
> 
> > org.eclipse.sdk.ide
> 
> This I think is the "branding bundle" for the Eclipse SDK "product". 
> 

I pushed in a patch in Bug 386885 which I think fixes this branding issue. We're now building org.eclipse.sdk.ide instead of org.eclipse.sdk.epp.


> In our Platform PDE build, we end up with two "products", one for "Platform"
> (only) and one for "Eclipse SDK". 
> 
> I'm probably stating the obvious, but in case that gives you a hint. 
> 
> (Can Tycho build two "products" in same run? I have a vague memory of some
> build system that could only do one at a time ... but ... very vague and
> probably something else not Tycho ... just thought I'd ask).

Yes, Tycho can build multiple products in the same run. We're actually building the following products at the moment in the R4 branch from eclipsebuilder.

platform
platform.sdk
rcp
rcp.config
rcp.sdk
sdk
Comment 6 Thanh Ha CLA 2012-08-13 12:00:34 EDT
(In reply to comment #3)
> (In reply to comment #1)
> > I believe the items below come from the generated features in
> > build.properties from org.eclipse.sdk feature.
> > 
> > org.eclipse.cvs.source
> > org.eclipse.jdt.source
> > org.eclipse.pde.source
> > org.eclipse.rcp.source 
> > 
> > There is discussion on this on the mailing list:
> >   http://dev.eclipse.org/mhonarc/lists/cbi-dev/msg00595.html
> > 
> > 
> 
> I don't think this is the right reference or thread these these 4 bundles. 
> 
> I think these are cases where we (in Platform PDE build) should NOT be
> generating these .source bundles because in fact there is no Java in them.
> (I could be wrong, so don't quote me :) 
> I think I've seen this discussed somewhere (a bug or cbi list) but do not
> recall where. 
> 
> The org.eclipse.equinox.launcher.source might be similar (no Java files) but
> just going by its name, I didn't check it.


Not sure if it's the same bug you're thinking of but there was some discussion on empty source bundles in Bug 379847
Comment 7 Thanh Ha CLA 2012-08-13 12:04:46 EDT
Below is an updated list of missing bundles in CBI platform build, as of today there is now 11 bundles.

javax.el.source
org.eclipse.cvs.source
org.eclipse.equinox.launcher.source
org.eclipse.jdt.source
org.eclipse.pde.source
org.eclipse.rcp.source

org.eclipse.jdt.doc.isv
org.eclipse.platform.doc.isv

org.eclipse.rcp.configuration_root.gtk.linux.x86_64
org.eclipse.rcp_root
toolingorg.eclipse.configuration
Comment 8 Paul Webster CLA 2012-09-17 10:05:27 EDT
The diff of IUs in the eclipse-SDK from  M20120909-2000 to our current aggregator 4.2.1 build:

92d91
< org.eclipse.cvs.source
193d191
< org.eclipse.equinox.launcher.source
313d310
< org.eclipse.jdt.doc.isv
327d323
< org.eclipse.jdt.source
389d384
< org.eclipse.pde.source
401d395
< org.eclipse.platform.doc.isv
411c405
< org.eclipse.rcp.configuration_root.gtk.linux.x86_64
---
> org.eclipse.rcp.configuration.feature.jar
414d407
< org.eclipse.rcp.source
421a415,416
> org.eclipse.sdk.ide.executable.gtk.linux.x86_64
> org.eclipse.sdk.ide.executable.gtk.linux.x86_64.eclipse
505d499
< toolingorg.eclipse.configuration
507a502
> toolingorg.eclipse.sdk.ide.application
509a505
> toolingorg.eclipse.sdk.ide.executable.gtk.linux.x86_64


(In reply to comment #1)
> 
> Regarding org.eclipse.jdt.doc.isv and org.eclipse.platform.doc.isv I think
> is being worked on in Bug 385410:
>   https://bugs.eclipse.org/bugs/show_bug.cgi?id=385410

From this bug, it looks like the fix was committed but org.eclipse.platform.doc.isv and org.eclipse.jdt.doc.isv are still missing.  All of the user doc is included.

Also, M20120909-2000 contains:
org.eclipse.rcp.configuration_root.gtk.linux.x86_64
toolingorg.eclipse.configuration

but our cbi build contains:
org.eclipse.rcp.configuration.feature.jar
org.eclipse.sdk.ide.executable.gtk.linux.x86_64
org.eclipse.sdk.ide.executable.gtk.linux.x86_64.eclipse
toolingorg.eclipse.sdk.ide.application
toolingorg.eclipse.sdk.ide.executable.gtk.linux.x86_64

PW
Comment 9 Paul Webster CLA 2012-09-17 10:07:37 EDT
(In reply to comment #8)
> org.eclipse.rcp.configuration.feature.jar
> org.eclipse.sdk.ide.executable.gtk.linux.x86_64
> org.eclipse.sdk.ide.executable.gtk.linux.x86_64.eclipse
> toolingorg.eclipse.sdk.ide.application
> toolingorg.eclipse.sdk.ide.executable.gtk.linux.x86_64

These extra bundles are covered by bug 386885

PW
Comment 10 Thanh Ha CLA 2013-12-19 16:03:44 EST
Considering Platform is releasing using CBI build now I think this issue is safe to close. More specific bugs should be open if there's any more issues.