Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 386847 - Omit use of deprecated GTK_RANGE_SLIDER_END and GTK_RANGE_SLIDER_START
Summary: Omit use of deprecated GTK_RANGE_SLIDER_END and GTK_RANGE_SLIDER_START
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M2   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-08-08 11:02 EDT by Anatoly Spektor CLA
Modified: 2013-05-24 09:34 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-08-08 11:02:56 EDT 
This patch omits use of GTK_RANGE_SLIDER_END and GTK_RANGE_SLIDER_START deprecated constants for newer GTK+ versions:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk_slider
Comment 1 Silenio Quarti CLA 2012-08-08 11:26:48 EDT 
Move the helpers to ScrollBar.java. They are not needed anywhere else.

Move the creation of the int arrays in the helpers inside of the if statement. They are not needed for the old code path.
Comment 3 Silenio Quarti CLA 2012-08-08 14:27:03 EDT 
I changed the helper so that it matches the new function gtk_range_get_slider_range() (instead of the old accessors). It looks better that way.

Fixed

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a61caa1cfed4d2ec7b9bccff2e9d74f32593118d