Community
Participate
Working Groups
I talked to Susan about that and it seems we can make better job on this page. For instance: - if you have no repositories and you try to open commit to review, you should see: You are trying to review contribution 160f4eefa006f6b74514a8f8a24a458a0b569e53 from ssh://git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git Unfortunately the commit can not be found in your workspace. To see it try one of the following: 1. Create new repository [Clone Repository] using ssh://sbrandys@git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git - if you have the repository but the commit is not there, you should see: You are trying to review contribution 160f4eefa006f6b74514a8f8a24a458a0b569e53 from ssh://git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git Unfortunately the commit can not be found in your workspace. To see it try one of the following: 1. Try to update your repositories or 2. Attach the remote to one of existing repositories or 3. Create new repository - if the commit exists, we could have that: You are trying to review contribution 160f4eefa006f6b74514a8f8a24a458a0b569e53 from ssh://git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git The commit can be found on the following repositories .... Advanced v you can also 1. Try to update your repositories or 2. Attach the remote to one of existing repositories or 3. Create new repository I hope the idea is clear.
https://github.com/edytaprzymus/orion.client/commit/12d2f369638f1a2e4b1429158861c548495106a6 My first solution for this problem
Test
https://github.com/edytaprzymus/orion.client/commit/e089bc401819e4bf942da035877df7ddcada2418 Commit better then the previous one. I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
Can I see a screenshot?
Created attachment 219796 [details] new descriptions
Created attachment 219798 [details] Suggestion
Created attachment 219799 [details] Suggestion 2
I would also start using wording suggested by Susan ie "Contribution Review", "Contribution Review Request" etc.
https://github.com/edytaprzymus/orion.client/commit/d082633c66ebcdfaec29b3fce2bc4d27cc630e31
Screenshots?
Created attachment 219856 [details] description2
https://github.com/edytaprzymus/orion.client/commit/c1fa2080a001173de206c4d729b00c9503e23e80 Here is slightly better commit. BTW, in this commit I also fixed bug I observed about cloning function in Contribution Request page
https://github.com/edytaprzymus/orion.client/commit/97c5cc33891f40a2a50811c1f31e5fa1e7a978f5 Please consider this commit, it is rebased to the master.
Wording on pages looks fine, but you also need to change the page name, variables in the code, etc.
https://github.com/edytaprzymus/orion.client/commit/45042f1356d0e678a52b850dc8f6a3ca635d57a0 Names changed
https://github.com/edytaprzymus/orion.client/commit/45042f1356d0e678a52b850dc8f6a3ca635d57a0 rebased
https://github.com/edytaprzymus/orion.client/commit/f10681176b2165761d15599dcac35feed5457d73 I meant this
https://github.com/edytaprzymus/orion.client/commit/7a75eaf67d89077f9c365680717beb9f7b2b1c30 Please consider this commit
https://github.com/edytaprzymus/orion.client/commit/c4ccf638666971b3ce0aed4fc9aa126c819aaea1
https://github.com/edytaprzymus/orion.client/commit/13b4e599c986fe8fb6e8a5d2be195c0477669ac4
Still not good. The "Ask for Review" dialog shows http://localhost:8080/git/pullRequest.html... I guess the same is sent to reviewers.
https://github.com/edytaprzymus/orion.server/commit/12e1a1aaf5f40e0afed5b4aeae1984b9d42526b4 I made changes also in server side Here is client side - I really tested it this time. https://github.com/edytaprzymus/orion.client/commit/b6fadb2e43740f594437f7201d74662ae5ef8149
https://github.com/edytaprzymus/orion.client/commit/66059977ba20386fd3b3153028d9a7eead0a4579 I just found one more little trace of old name in client side, here it's removed
Ok. Both client and server parts merged to master.
