This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 386825 - Merge 'Pull Request Url' and 'Ask for review' actions
Summary: Merge 'Pull Request Url' and 'Ask for review' actions
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Git (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.0 M2   Edit
Assignee: Edyta Przymus CLA
QA Contact:
URL:
Whiteboard: gsoc2012
Keywords:
: 386826 (view as bug list)
Depends on: 386845
Blocks:
  Show dependency tree
 
Reported: 2012-08-08 08:09 EDT by Szymon Brandys CLA
Modified: 2012-08-17 06:47 EDT (History)
3 users (show)

See Also:

Attachments
Suggestions (5.15 KB, image/png)
2012-08-13 04:09 EDT, Szymon Brandys CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2012-08-08 08:09:50 EDT 
I would merge these two actions. There would be just one 'Ask for Review' action. When clicked, the prompt would allow to select the reviewer. Clicking 'More' would show a dialog where you could still select the reviewer, but you would also see the url to paste in mail or communicator.
Comment 1 Szymon Brandys CLA 2012-08-08 08:10:51 EDT 
*** Bug 386826 has been marked as a duplicate of this bug. ***
Comment 2 Susan McCourt CLA 2012-08-08 10:13:33 EDT 
I mentioned to Szymon that we probably shouldn't be using the term "pull request" because this has a specific github concept (https://help.github.com/articles/using-pull-requests/) and using that name might imply that we somehow handle the github pull request URL's.
Comment 3 Edyta Przymus CLA 2012-08-08 10:15:39 EDT 
I understand. Have you any suggestion how should we rename this tool?
Comment 4 Susan McCourt CLA 2012-08-08 10:26:18 EDT 
I think calling it a "Contribution" is a good idea because we have the notion of committers who push commits and then contributors ask for review.

So some ideas...

The action could be:
"Review Contribution"

The page name (noun) I'm not sure, maybe
"Commit Contribution"

That sounds so formal/boring though, I wish we had a more unique/fun name.
Maybe Gosia will have an idea (she came up with String Xternalizr)
or Ken?  cc'ing both
Comment 5 Edyta Przymus CLA 2012-08-08 10:28:22 EDT 
Thank you for this proposals. I think I will create separate bug to change the name for all components as soon as we will make a decision about it.
Comment 6 Szymon Brandys CLA 2012-08-08 10:31:24 EDT 
So maybe K'mit Reviewr ;) I think 'Review Request' sounds good too. Edyta, once we choose the new name, please fix the code too (variables, function names etc), not only labels.
Comment 7 Szymon Brandys CLA 2012-08-08 10:32:27 EDT 
(In reply to comment #5)
> Thank you for this proposals. I think I will create separate bug to change the
> name for all components as soon as we will make a decision about it.

Sure, we can raise a separate name just to refactor names.
Comment 8 Edyta Przymus CLA 2012-08-08 10:41:01 EDT 
https://github.com/edytaprzymus/orion.client/commit/7640bc8e44687bec6a512a15198671b29b39ee19
Here just a commit with the topic of current bug - both commands merged
Comment 9 Edyta Przymus CLA 2012-08-12 18:27:06 EDT 
I wrote all this code and have the rights to contribute it to Eclipse under the
eclipse.org web site terms of use.
Comment 10 Szymon Brandys CLA 2012-08-13 04:09:01 EDT 
Created attachment 219793 [details]
Suggestions

I would suggest changes as per the attached screenshot.
Comment 11 Edyta Przymus CLA 2012-08-13 05:17:56 EDT 
https://github.com/edytaprzymus/orion.client/commit/5469d90b5da9aeee62506da163db4d6d9b8ad3b2

Here I implemented Szymon's suggestions
Comment 12 Szymon Brandys CLA 2012-08-14 06:23:31 EDT 
You left unused keys in gitmessages.js and again the code is not rebased on top of master.
Comment 14 Szymon Brandys CLA 2012-08-17 06:47:58 EDT 
Merged to master.