Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 386809 - Patch tests fails in I20120807-0800 build
Summary: Patch tests fails in I20120807-0800 build
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.3 M1   Edit
Assignee: Dani Megert CLA
QA Contact:
URL: http://download.eclipse.org/eclipse/d...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-08 04:56 EDT by Malgorzata Janczarska CLA
Modified: 2012-08-09 08:01 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2012-08-08 04:56:48 EDT 
Some tests testing patches fail in I20120807-0800. Tests also fail locally.
Comment 1 Malgorzata Janczarska CLA 2012-08-08 05:48:49 EDT 
I reverted commit 2632475c64c20d5354ade3e3772023573dc7a500 and tests passed, so I assume that bug 123787 has caused this failures.
Comment 2 Dani Megert CLA 2012-08-08 05:53:28 EDT 
.
Comment 3 Malgorzata Janczarska CLA 2012-08-08 06:10:27 EDT 
(In reply to comment #1)
> I reverted commit 2632475c64c20d5354ade3e3772023573dc7a500...
I don't have commit rights, so I couldn't push the reverted commit.
Comment 4 Dani Megert CLA 2012-08-08 06:12:12 EDT 
(In reply to comment #3)
> (In reply to comment #1)
> > I reverted commit 2632475c64c20d5354ade3e3772023573dc7a500...
> I don't have commit rights, so I couldn't push the reverted commit.

Did you actually check whether the failing tests make sense?
Comment 5 Dani Megert CLA 2012-08-08 06:15:13 EDT 
.
Comment 6 Malgorzata Janczarska CLA 2012-08-08 06:24:04 EDT 
(In reply to comment #4)
> Did you actually check whether the failing tests make sense?
Tests fail on importing some patches that where created for test purposes, they give "invalid patch" error, so I suppose the tests make sense, but patches format maybe need to be updated. I don't know what exactly causes patches import to fail and why they could be imported before.
Comment 7 Dani Megert CLA 2012-08-08 08:45:48 EDT 
Fixed. See bug 123787 comment 11.
Comment 8 Dani Megert CLA 2012-08-09 08:01:36 EDT 
Verified in I20120808-2000: test are green again.