This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 386698 - Detached view window lacking window controls
Summary: Detached view window lacking window controls
Status: CLOSED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard: candidate43
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 12:49 EDT by Konstantin Komissarchik CLA
Modified: 2013-05-09 10:03 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Komissarchik CLA 2012-08-06 12:49:56 EDT
When a view is detached the resulting window is lacking normal window controls. This is quite confusing. It took me a while to figure out how to close this window (by closing the view inside of it) and I watched others struggle with this as well.

The detached view window should have the normal close, minimize, maximize controls.
Comment 1 Eric Moffatt CLA 2012-08-14 10:54:14 EDT
This may not be doable on all platforms. Some won't let you show min / max buttons unless the shell is completely trimmed.

I'm going to be doing some other work on DW's this week and I'll bear this in mind while I'm in the code.
Comment 2 Eric Moffatt CLA 2012-08-20 13:37:56 EDT
I've changed the WBWRenderer to make a DW a full Shell in order to allow it to show all the relevant controls (minus the 'minimize' button for now).

It looks somewhat bogus because it's lacking a title, perhaps I should add an 'active part' listener that would update the shell's title with the label of the last view active in it ??
Comment 3 Bill Chen CLA 2012-10-07 12:53:27 EDT
Please also make sure the Window is displayed in the task bar and cannot be displayed out of the currently available screens.

I detached a file at work on to a secondary screen for reference and when I took my laptop home, the detached window is still on the now non-existent secondary screen!! Because it does not show up in the task bar or the task manager, I cannot move it back to the main (and only) screen.
Comment 4 Eric Moffatt CLA 2012-10-09 11:32:29 EDT
Doh! I thought I'd already handled the case where a DW was off the screen by doing what we do in 3.x...adjust it so that it's at least partially visible.

BTW, what you think of an enhancement that could detect which of the two screen setups you are currently using (docked / 2-screen vs undocked / 1-screen) and gave you a unique layout for each ?

Moving to 4.2.2 to do something about the 'disappearing' DW's.
Comment 5 Bill Chen CLA 2012-10-09 12:12:09 EDT
Hi, this problem no longer exists Windows 7 with version 4.2.1 now. I think what made the extra buttons appear also allows the window to be automatically moved back to the available screens once the screen it was on is disconnected.

I have also tested my Ubuntu box at work and it seems it will automatically move window back as well even with 4.2. (I haven't tried all possible combinations thorugh.)
Comment 6 Eric Moffatt CLA 2012-10-09 15:02:23 EDT
Bill, thanks for the additional input...we'll at least test this out to make sure *we* are satisfied with the current handling.
Comment 7 Nobody - feel free to take it CLA 2013-04-09 06:27:37 EDT
This works for me too on the 4.3 milestones.
Comment 8 Eric Moffatt CLA 2013-05-09 10:03:43 EDT
This works for me as well...