Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 386145 - Use gtk_widget_get_window() instead of GTK_WIDGET_WINDOW in newer GTK+
Summary: Use gtk_widget_get_window() instead of GTK_WIDGET_WINDOW in newer GTK+
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M2   Edit
Assignee: Arun Thondapu CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-07-27 11:44 EDT by Anatoly Spektor CLA
Modified: 2013-05-24 09:34 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-07-27 11:44:12 EDT 
Build Identifier: I20120608-1400

This patch omits use of GTK_WIDGET_WINDOW in newer GTK+ versions thus avoiding G_SEAL warning:

http://fedorapeople.org/gitweb?p=aspektor/public_git/eclipse.platform.swt.git;a=commit;h=99bd3da7604c07fbb2938174f2b3dfe0e0f2b234

Reproducible: Always
Comment 1 Anatoly Spektor CLA 2012-07-27 12:30:21 EDT 
 Please ignore previous patch, as there is incorrect  os_custom.h  and use the
 patch below:
 
 http://fedorapeople.org/gitweb?p=aspektor/public_git/eclipse.platform.swt.git;a=commit;h=5843ab624f1985a1a773e0a4e88eebad1a012189
 
 
 Sorry for the confusion.
 
 Regards,
 
 Anatoly
Comment 2 Silenio Quarti CLA 2012-08-01 17:40:11 EDT 
Please add Widget.gtk_widget_get_window() helper function. Classes outsize of the Widget hierarchy are good as is.
Comment 3 Anatoly Spektor CLA 2012-08-03 10:14:11 EDT 
What I did:

1. Added helper function to Widget.java gtk_widget_get_window
2. Put version guard implementation into Widget.java
3. Where possible replaced  implementation with function call to helper function
4. Fixed Formatting


 Please find revised patch here:

  http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk_widget_get_window_&id=4e304bf58fa28343289565a3b93efc96a15fd931



Regards,

Anatoly
Comment 4 Arun Thondapu CLA 2012-08-06 09:09:32 EDT 
Thanks!

Fixed - http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=31b7a613958123368d896ee9b0a636412f2a598b and http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=77a864c617c9320310a0566ced42ef43c6615a47

Silenio, there are some spurious changes in os.c because of some conflicts in my workspace, I hope it doesn't cause any issues.
Comment 5 Silenio Quarti CLA 2012-08-08 09:47:22 EDT 
(In reply to comment #4)
> Thanks!
> Silenio, there are some spurious changes in os.c because of some conflicts
> in my workspace, I hope it doesn't cause any issues.

os.c is generated. It should be fine as long as the generated code got released. I just checked and it seems to be the case.