Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 386022 - Title of ErrorDialog in WorkbenchStatusReporter should be externalized
Summary: Title of ErrorDialog in WorkbenchStatusReporter should be externalized
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC All
: P3 minor (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-26 06:19 EDT by Kamil Piętak CLA
Modified: 2012-10-30 16:47 EDT (History)
5 users (show)

See Also:

Attachments
Patch for WorkbenchStatusReporter (1.25 KB, patch)
2012-07-26 07:08 EDT, Kamil Piętak CLA 		no flags Details | Diff
Fix (1.20 KB, patch)
2012-07-26 07:09 EDT, Nobody - feel free to take it CLA 		Michael_Rennie: iplog+
Michael_Rennie: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kamil Piętak CLA 2012-07-26 06:19:46 EDT 
Build Identifier: Version: Juno Release Build id: 20120614-1722

In the current implementation of WorkbenchStatusReporter title of ErrorDialog is fixed (as Internal Error). 

When running non-english application the dialog title doesn't fit to the message.

Reproducible: Always

Steps to Reproduce:
1. Just run any non-english application that uses WorkbenchStatusReporter.
Comment 1 Kamil Piętak CLA 2012-07-26 07:08:14 EDT 
Created attachment 219205 [details]
Patch for WorkbenchStatusReporter

This is a simple patch for the bug.
Comment 2 Nobody - feel free to take it CLA 2012-07-26 07:09:49 EDT 
Created attachment 219206 [details]
Fix

Fix.

@Paul: this is to be moved to platform/ui
Comment 3 Nobody - feel free to take it CLA 2012-07-26 07:12:40 EDT 
Thanks Kamil. Next time say beforehand that you're going to provide a patch so there's no patch collision ;)
Comment 4 Kamil Piętak CLA 2012-07-26 09:00:30 EDT 
Thanks for quick reply and the fix. 

Of course, in the future I notify about possible patches.
Comment 5 Michael Rennie CLA 2012-10-16 14:13:03 EDT 
Comment on attachment 219206 [details]
Fix

Patch looks good.
Comment 6 Michael Rennie CLA 2012-10-16 14:14:19 EDT 
pushed patch to: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=dd65342c6618de77c76bb588df291b813bf52da3

Thanks Sopot and Kamil.
Comment 7 Curtis Windatt CLA 2012-10-30 16:47:56 EDT 
Verified the fix is in master for I20121030-0800