Community
Participate
Working Groups
On pullRequest page we should be able to add remoteUrl to the existing clone. Right now we can just create a new clone based on the given url.
https://github.com/edytaprzymus/orion.server/commit/ea5324333ab5a3a0f8e8b469621a24afb220774a New section on PullRequest page, just at the bottom of it.
Could you attach a screenshot, please?
Created attachment 219354 [details] Add remote dialog. You have to type remote name.
I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
https://github.com/edytaprzymus/orion.client/commit/4046b2f3643376ca87a9da9468494ab64cece4a4 Fetching automatically after adding a remote is added.
https://github.com/edytaprzymus/orion.client/commit/3aa0dcc0e70ad6331788300d304dc3873ad74663
Created attachment 219577 [details] Something is broken in the latest version See areas marked with arrows.
Use slideouts instead of prompts for collecting simple data like remote name. I tried to use "Add remote and fetch" for a remote that needs credentials. It failed.
Created attachment 219588 [details] Wrong section title I started completely new user and have no repos. The header marked on the screenshot is obviously wrong.
(In reply to comment #9) > I started completely new user and have no repos. The header marked on the > screenshot is obviously wrong. I looked at the latest commit. The header is still wrong. I used this url http://localhost:8080/git/pullRequest.html#git://github.com/edytaprzymus/orion.client.git_1d193f163aaa2e301699fd85c16cd2d1eccdcf95 on my local Orion server for a brand new user (no repos). I chose to clone, but when it was done I still saw no commit to open and no repos to fetch. So it seems to be worse than the previous version.
Szymon, did yoy try this commit? https://github.com/edytaprzymus/orion.client/commit/c0ef89005f6e23ae41ec984214b7e9bd5d1aa16d Because I just made test case you described in latest comment and such a behaviour didn't occur..
Please rebase the code and make sure it still works for you.
https://github.com/edytaprzymus/orion.client/commit/ca5d6ee7adf64c81f40a842cc18fda4c218f94ac Rebased commit - it works for me as supposed.
(In reply to comment #13) > https://github.com/edytaprzymus/orion.client/commit/ca5d6ee7adf64c81f40a842cc18fda4c218f94ac > > Rebased commit - it works for me as supposed. I guess "Choose repository" key in gitmessages.js is no more used.
I fixed remaining issues and released the fix to master.
