385037 – ShowViewDialog - Enable multi-user environment

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 385037 - ShowViewDialog - Enable multi-user environment

Summary: ShowViewDialog - Enable multi-user environment

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.2
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.2.2
Assignee:	Brian de Alwis
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-07-13 07:04 EDT by Lars Vogel
Modified:	2013-01-17 14:14 EST (History)
CC List:	3 users (show)

See Also:

Attachments
Patch (2.00 KB, patch) 2012-07-13 08:15 EDT, Lars Vogel	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2012-07-13 07:04:28 EDT

ShowViewDialog is using direct access to labels in IDialogConstants. 

I think we should use the new JFace API for this access.

Comment 1 Lars Vogel

2012-07-13 08:15:34 EDT

Created attachment 218693 [details]
Patch

Comment 2 Eric Moffatt

2012-11-07 10:31:10 EST

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_2_maintenance&id=699191aabd7973643a37575c2ba93419fadcead7

This updates both versions of the ShowViewDialog (thanks Sopot!).

Comment 3 Lars Vogel

2012-11-07 10:38:13 EST

@Eric: I assume you planned saying "Thanks, Lars" ;-)

Comment 4 Markus Keller

2012-11-15 12:34:53 EST

(In reply to comment #2)
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?h=R4_2_maintenance&id=699191aabd7973643a37575c2ba93419fadcead7
> 
> This updates both versions of the ShowViewDialog (thanks Sopot!).

This commit is bogus. Just open the dialog to see it.
Lars' patch looks like an actual fix, but I haven't tested it.

Comment 5 Brian de Alwis

2012-12-06 08:54:21 EST

Reported separately as bug 395913.  Fixed in R4_2_maintenance:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_2_maintenance&id=f58eeeba9a8cb3c7a1352091b0d4cefe365b7ba1

Comment 6 Lars Vogel

2012-12-06 09:06:00 EST

Thanks Brian, commit looks better this time. :-)

Comment 7 Eric Moffatt

2013-01-17 14:14:17 EST

Verified (visually) in M20130116-1800.