Community
Participate
Working Groups
Build Identifier: A set of icons with alpha transparency is needed to support high quality dark themes. The actual set does not fit this need. Reproducible: Always
I suggest to make this bug specific to the platform icons. Afterwards we might extend this via new bugs to different areas.
Created attachment 232914 [details] comparsion between png <-> eclipse gif
Created attachment 232915 [details] eclipse menu bar in dark theme
Interestingly third-party applications use transparency, but the built-in icons don't (they're 16x16 gifs). I also wasn't able to find the eclipse icons in a better quality then 16x16 gifs (see http://eclipse-icons.i24.cc/ for the whole list). Does someone if they're available in a HQ or as png?
Tony, would you contribute your icons from https://code.google.com/p/eclipse-svg-icons/ to the platform?
Note: contacted John via email to asked if platform can handle svg for icons. To my knowledge png files are required, which would require a conversion.
(In reply to Lars Vogel from comment #5) > Tony, would you contribute your icons from > https://code.google.com/p/eclipse-svg-icons/ to the platform? Sure. Would it be possible to move the icon sources to a git repo at eclipse.org? We currently push from our internal git infrastructure to google code. Would it make sense to perform some kind of IP assignment or would a contribution with my CLA be adequate?
I think the icons belong the the plug-ins which provides / use them. Or is there a reason to keep them separate? In case svg images can be used directly (lets see what John says) we could simply copy them into the icon folder.
Rendered png images would replace the current images in the plugin projects but I was thinking that having a common repository with the source artwork might be useful for future improvements and modifications, creating new icons, etc.
I agree to that Tony. Adding Wayne. @Wayne, Tony would like to contribute new Eclipse icons to Eclipse.org. What would be the right place to hold them? If there is no good place I suggest to host them in the e4 project.
(In reply to Tony McCrary from comment #7) > Would it make sense to perform some kind of IP assignment or would a > contribution with my CLA be adequate? Just to be clear if you contribute them to an Eclipse project you are still the copyright holder - just pointing it out because some open source projects work differently. We would just need to create a CQ and attach the source to initiate a legal review at the Eclipse Foundation. However it seems to me some investigation is needed on our side to figure out whether we can actually consume them, how we would convert them, etc, before going forward with a contribution.
(In reply to Lars Vogel from comment #10) > I agree to that Tony. Adding Wayne. > > @Wayne, Tony would like to contribute new Eclipse icons to Eclipse.org. What > would be the right place to hold them? If there is no good place I suggest > to host them in the e4 project. The icons should ideally be held by the projects that use them. Putting them in e4 would be my second choice. SVG format icons feels like something you might think of as a source format with the scaled PNGs as the bin format. With that in mind, I would expect the hosting project to hold the SVG as well as PNGs.
(In reply to John Arthorne from comment #11) > (In reply to Tony McCrary from comment #7) > > Would it make sense to perform some kind of IP assignment or would a > > contribution with my CLA be adequate? > > Just to be clear if you contribute them to an Eclipse project you are still > the copyright holder - just pointing it out because some open source > projects work differently. We would just need to create a CQ and attach the > source to initiate a legal review at the Eclipse Foundation. However it > seems to me some investigation is needed on our side to figure out whether > we can actually consume them, how we would convert them, etc, before going > forward with a contribution. Understood about the copyright. We've added a PNG rasterization utility to render the SVG images into PNGs at various sizes, which is the default ant task.
(In reply to Wayne Beaton from comment #12) > (In reply to Lars Vogel from comment #10) > > I agree to that Tony. Adding Wayne. > > > > @Wayne, Tony would like to contribute new Eclipse icons to Eclipse.org. What > > would be the right place to hold them? If there is no good place I suggest > > to host them in the e4 project. > > The icons should ideally be held by the projects that use them. Putting them > in e4 would be my second choice. > > SVG format icons feels like something you might think of as a source format > with the scaled PNGs as the bin format. With that in mind, I would expect > the hosting project to hold the SVG as well as PNGs. I understand your viewpoint, however, the icons present a singular platform style, so it may be frustrating to fetch many different projects for someone working on the art. They icons reuse various elements and idioms across projects.
I agree with both Tony and Wayne. From a design point of view it would be great if we would have a single repository project as home for a master icons. So we can make sure that they all fit together. But since every project is in charge of the used icons, I would suggest that - every project keeps a private copy of the used icons - if new icon art is designed for a specific project, there should be a way to contribute it back to the reference repository project - If there are new icon versions in the reference repository, every project may update the local icons
We could create a new resource plug-in for platform UI which holds all provided icons and every plug-in which uses it could make a copy of the required icons.
Wayne, where do we find the info, how to create the CQ? I guess that is in any case necessary.
Silenio Quarti confirmed that the current code does not support the direct usage of SVG icons. As soon as we learn how to issue the CQ, we can start replacing the icons.
(In reply to Lars Vogel from comment #17) > Wayne, where do we find the info, how to create the CQ? I guess that is in > any case necessary. The IP process makes no distinction between code and image contributions. Use the normal CQ creation process. http://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire Follow the "Contribution of code to be maintained at eclipse.org" workflow.
(In reply to Tony McCrary from comment #14) > I understand your viewpoint, however, the icons present a singular platform > style, so it may be frustrating to fetch many different projects for someone > working on the art. They icons reuse various elements and idioms across > projects. I understand your concern. We really have no mechanism to receive contributions outside of a project. I guess that the ideal would be to create an "images" project, but that's probably too heavyweight at this point. Perhaps a good starting point would be to start a work area within the e4 incubator to hold all these image contributions. If at some point in the future we reach some kind of critical mass, we may consider creating a separate project. Projects outside of e4 that want to use the icons would have to open a CQ for that reuse (but this is true for any sort of IP sharing between projects anyway).
Tony, do you need help with the CQ?
(In reply to Lars Vogel from comment #21) > Tony, do you need help with the CQ? Yes, thank you. I'm not a committer so I don't think I can start one. We are working on the remaining icons in the platform component. I'm thinking we'll create a set of PNG replacements and we can worry about the SVG sources later, does that sound okay? We'll need to replace the icons in platform and patch the sources to load the new icons.
I plan to add the svg (and .png) files via an additional resource plug-in to eclipse ui. Any preferences for the name of the plug-in? I would call it "org.eclipse.ui.resources".
(In reply to Lars Vogel from comment #23) > I plan to add the svg (and .png) files via an additional resource plug-in to > eclipse ui. Any preferences for the name of the plug-in? I would call it > "org.eclipse.ui.resources". Of course the png files would also be available in the plug-ins which use them, but a central place for storing the svg files is nice IMHO in case we need later to create png files in different resolutions of in case another project whats to use the icons.
(In reply to Lars Vogel from comment #23) > I plan to add the svg (and .png) files via an additional resource plug-in to > eclipse ui. Any preferences for the name of the plug-in? I would call it > "org.eclipse.ui.resources". org.eclipse.ui.images? Also, would we not just provide the SVG and PNG files in that bundle? Any plugin that want's to use them can specify platform:/plugin/org.eclipse.ui.images/...path... right? PW
> org.eclipse.ui.images? > > Also, would we not just provide the SVG and PNG files in that bundle? Any > plugin that want's to use them can specify > platform:/plugin/org.eclipse.ui.images/...path... right? > > PW Thanks for the suggestion Paul, sounds great to me. My assume was that every plug-in should be self-contained with its resources, e.g., icons. But I personally love your idea of having one central resource bundle which everyone can simple refer to.
(In reply to Lars Vogel from comment #26) > > org.eclipse.ui.images? > > > > Also, would we not just provide the SVG and PNG files in that bundle? Any > > plugin that want's to use them can specify > > platform:/plugin/org.eclipse.ui.images/...path... right? > > > > PW > > Thanks for the suggestion Paul, sounds great to me. My assume was that every > plug-in should be self-contained with its resources, e.g., icons. But I > personally love your idea of having one central resource bundle which > everyone can simple refer to. We could also use the bundle loading mechanism (maybe fragments) for high resolution image support. So for example, if you're on a retina mac it could load a bundle with high res icons, where users on a traditional display would get the normal icons. This way the code would just request the image it needs and not have to worry about which resolution is involved.
> We could also use the bundle loading mechanism (maybe fragments) for high > resolution image support. So for example, if you're on a retina mac it could > load a bundle with high res icons, where users on a traditional display > would get the normal icons. This way the code would just request the image > it needs and not have to worry about which resolution is involved. Sounds great. Good you open a new bug report for this feature request. Implementation suggestions are very welcome.
(In reply to Lars Vogel from comment #28) > > We could also use the bundle loading mechanism (maybe fragments) for high > > resolution image support. So for example, if you're on a retina mac it could > > load a bundle with high res icons, where users on a traditional display > > would get the normal icons. This way the code would just request the image > > it needs and not have to worry about which resolution is involved. > > Sounds great. Good you open a new bug report for this feature request. > Implementation suggestions are very welcome. We've optimized the icons, there's a pretty drastic reduction in uncompressed SVG size. Also, the e4 edit icons have been generated and added. Everything has been pushed to google code.
> We've optimized the icons, there's a pretty drastic reduction in > uncompressed SVG size. Also, the e4 edit icons have been generated and > added. Everything has been pushed to google code. Can you confirm that no copyright relevant change did happen? Otherwise I have to go through a CQ again.
(In reply to Lars Vogel from comment #30) > > We've optimized the icons, there's a pretty drastic reduction in > > uncompressed SVG size. Also, the e4 edit icons have been generated and > > added. Everything has been pushed to google code. > > Can you confirm that no copyright relevant change did happen? Otherwise I > have to go through a CQ again. The copyright status is identical.
Thanks Tony, you are awesome! Fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c5b4d514548008920aa73f7bfdeea46205b1bdd6 I opened Bug 421291 and Bug 421292 for the next actions.
Fixed
Thanks Tony.
See Bug 421344 for some continued discussion on getting the bundle shape correct. PW
We still have work to do, e,g. images need to be moved and icons needs to be re-rendered to avoid fussy icons but the initial contribution is save in the Git repo. Verified
