384955 – Show content on git repository(ries) in a more dynamic way

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 384955 - Show content on git repository(ries) in a more dynamic way

Summary: Show content on git repository(ries) in a more dynamic way

Status:	RESOLVED FIXED

Alias:	None

Product:	Orion
Classification:	ECD
Component:	Client (show other bugs)
Version:	1.0
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	1.0 M1
Assignee:	Maciej Bendkowski
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (1):	371389 (view as bug list)
Depends on:	385706
Blocks:	386943
	Show dependency tree

Reported:	2012-07-12 10:29 EDT by Szymon Brandys
Modified:	2012-09-04 09:48 EDT (History)
CC List:	2 users (show)

See Also:

Flags:	malgorzata.tomczyk: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Szymon Brandys

2012-07-12 10:29:44 EDT

To show repositories page we do the following:
- we get the list of repos
- per each repo we get extra details e.g. info about changes to commit or to push
- then we show the page

Should be:
- we get the list of repos
- show repositories with actions
- we make calls to get extra details (concurrently for all repos)
- show progress indicator per each repo until extra details are retrieved, then replace the progress indicator with details

Comment 1 Maciej Bendkowski

2012-07-24 08:35:26 EDT

Pull request: http://orion.eclipse.org/git/pullRequest.html#git://github.com/maciej-bendkowski/orion.client_dd1d81e2a0131991101caa4e2f5d9b9a33fa3fd5

Comment 2 Maciej Bendkowski

2012-07-24 09:47:51 EDT

(In reply to comment #1)
> Pull request:
> http://orion.eclipse.org/git/pullRequest.html#git://github.com/maciej-bendkowski/orion.client_dd1d81e2a0131991101caa4e2f5d9b9a33fa3fd5

Due to a new found bug, another pull request:
http://orion.eclipse.org/git/pullRequest.html#git://github.com/maciej-bendkowski/orion.client_817f04df18fcd9352eb9bf65dea532bfca3475b1

Comment 3 Maciej Bendkowski

2012-07-30 09:06:14 EDT

Next solution proposal: https://github.com/maciej-bendkowski/orion.client/commit/d95af090c031bc707cb728aa75362fdffdb5edad

Quick summary:

DynamicContent is meant to be  a generalization of dynamic population and rendering using the model-explorer-renderer scheme. The DynamicContentModel provides population logic, DynamicContentExplorer handles the base scheme for dynamic loading and DynamicContentRenderer supplies you with basic render methods and a default progress indicator.

Comment 4 Maciej Bendkowski

2012-08-08 11:16:03 EDT

Fix: https://github.com/maciej-bendkowski/orion.client/commit/4d6c844f2ff4b1506dd4c5a4ca6d9e52a55ba34e

Comment 5 Malgorzata Janczarska

2012-08-08 12:29:13 EDT

Pushed, thanks Maciek!

Comment 6 Szymon Brandys

2012-08-09 11:45:16 EDT

Some comments:
- I think we were talking about different look of progress indicator, maybe the one we use in "select remote to push"dialog
- There should be more space between the item label and the indicator
- We also wanted to use the same indicator for section progress and item progress

I will just open a new bug for it...

Comment 7 Maciej Bendkowski

2012-09-04 09:48:22 EDT

*** Bug 371389 has been marked as a duplicate of this bug. ***