Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 384926 - "Link with Editor and Selection" in egit history view is broken
Summary: "Link with Editor and Selection" in egit history view is broken
Status: CLOSED DUPLICATE of bug 384068
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 08:21 EDT by Dieter Guendisch CLA
Modified: 2012-08-13 12:05 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dieter Guendisch CLA 2012-07-12 08:21:49 EDT
In the egit 2.0 version with juno the feature “Link with Editor and Selection” in the History view is unusable.
I normally have this turned on, so that I can select a repository in the “Git Repositories” view and have the history adjusted automatically.
 
However as soon as I click into the History view, it now immediately reverts to narrowing down the history to the file that is currently opened in the eclipse java editor!?
Don’t know if this is a egit problem or more a focus problem in juno.
 
The same works fine till eclipse 3.7
Comment 1 Robin Stocker CLA 2012-07-12 09:47:19 EDT
Seems like the something around focus handling has changed in Juno. Does anyone know details?
Comment 2 Robin Stocker CLA 2012-07-27 03:25:55 EDT
Can someone who knows the right product/component please reassign this to org.eclipse.team (or maybe workbench)? The problem also exists for the CVS provider:

When clicking on the History view, setInput is triggered like this:

GitHistoryPage.setInput(Object) line: 1106
GenericHistoryView.getPageRec(IWorkbenchPart) line: 575
GenericHistoryView(PageBookView).partActivated(IWorkbenchPart) line: 752
GenericHistoryView.showHistoryPageFor(Object, boolean, boolean, IHistoryPageSource) line: 559
GenericHistoryView.showHistory(Object) line: 818
GenericHistoryView.editorActivated(IEditorPart) line: 752
GenericHistoryView$1.partVisible(IWorkbenchPartReference) line: 334

The Object argument to setInput is an IFile, so showing the history of the file is the right thing for GitHistoryPage to do.

The problem is that it should never come to this in the first place. I tried the same thing with the CVS history page, and the problem also exists there.
Comment 3 Dani Megert CLA 2012-08-13 12:05:07 EDT

*** This bug has been marked as a duplicate of bug 384068 ***