Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 38412 - [Actions] Navigator tree cell editors too small
Summary: [Actions] Navigator tree cell editors too small
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Andre Weinand CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 49208 64296 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-06-04 10:50 EDT by Andre Weinand CLA
Modified: 2004-06-24 04:40 EDT (History)
5 users (show)

See Also:

Attachments
Tree cell editor too small (16.52 KB, image/jpeg)
2003-06-04 10:51 EDT, Andre Weinand CLA 		no flags Details
patch for RenameResourceAction.java (2.90 KB, patch)
2004-03-11 08:14 EST, Andre Weinand CLA 		no flags Details | Diff
patch with additional check for system property (1.53 KB, patch)
2004-06-02 04:46 EDT, Andre Weinand CLA 		no flags Details | Diff
patch with additional check for system property (4.05 KB, patch)
2004-06-02 17:50 EDT, Andre Weinand CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andre Weinand CLA 2003-06-04 10:50:47 EDT 
I20030528
MacOS X 10.2.6

- start Eclipse
- in the Navigator select any resource
- from the context menu select "Rename"
Observe:  the cell editor field is too small and leaves only the upper half of the text visible.
Comment 1 Andre Weinand CLA 2003-06-04 10:51:54 EDT 
Created attachment 5054 [details]
Tree cell editor too small
Comment 2 Steve Northover CLA 2003-06-17 17:34:28 EDT 
Text widget with no border is now smaller.  Waiting on VI for fixes to 
TreeEditor etc.
Comment 3 Steve Northover CLA 2003-06-17 17:35:08 EDT 
VI, can you implement the vertical alignment thing?
Comment 4 Steve Northover CLA 2003-06-17 17:36:07 EDT 
When TreeEditor etc. is fixed, someone will have to contact JFace with the 
good code.
Comment 5 Veronika Irvine CLA 2003-06-20 16:49:12 EDT 
Vertical alignment now implemented on TreeEditor.

Will investigate what is required by JFace.
Comment 6 Andre Weinand CLA 2003-12-23 08:37:23 EST 
*** Bug 49208 has been marked as a duplicate of this bug. ***
Comment 7 Andre Weinand CLA 2004-03-11 05:41:59 EST 
We could gain another two pixel of vertical space, if we can get rid of the black border.
The Mac has a focus ring, so there is no need to have a black frame too.
Comment 8 Andre Weinand CLA 2004-03-11 06:37:39 EST 
I realized that this cell editor is custom made in the RenameResourceAction.
Moving to platform.ui.
Increased severity to major because renaming resources is really hampered by this problem.
Comment 9 Andre Weinand CLA 2004-03-11 07:06:11 EST 
In addition, the Text doesn't seem to use the same font as the underlying Tree.
Comment 10 Andre Weinand CLA 2004-03-11 08:14:29 EST 
Created attachment 8494 [details]
patch for RenameResourceAction.java

This patch fixes both problems for me.
(Apply to project).
Comment 11 Andre Weinand CLA 2004-04-12 10:07:00 EDT 
fixed and released for I20040413
Comment 12 Andre Weinand CLA 2004-05-27 06:14:06 EDT 
*** Bug 64296 has been marked as a duplicate of this bug. ***
Comment 13 Andre Weinand CLA 2004-06-02 04:44:11 EDT 
In M9 the system property "org.eclipse.swt.internal.carbon.noFocusRing" has been introduced
as a temporary workaround for bug #28842. The existence of the property turns the native focus ring 
off.
As a consequence the fix for this problem must now include a test for existence of the system property
"org.eclipse.swt.internal.carbon.noFocusRing". Without this, the cell editor will have no border at all.
Comment 14 Andre Weinand CLA 2004-06-02 04:46:23 EDT 
Created attachment 11445 [details]
patch with additional check for system property
Comment 15 Andre Weinand CLA 2004-06-02 04:46:55 EDT 
RC2 candidate
Comment 16 Silenio Quarti CLA 2004-06-02 11:29:26 EDT 
You have to check if the editor is in a main window too. The focus ring is 
drawn on dialogs.
Comment 17 Andre Weinand CLA 2004-06-02 11:51:52 EDT 
Thanks for mentioning this.
Comment 18 Andre Weinand CLA 2004-06-02 17:50:28 EDT 
Created attachment 11505 [details]
patch with additional check for system property
Comment 19 Andre Weinand CLA 2004-06-02 17:51:26 EDT 
Michael, OK to fix for 3.0 RC2 ?
Comment 20 Andre Weinand CLA 2004-06-03 18:16:24 EDT 
Fixed for I20040604
Comment 21 Ines Khelifi CLA 2004-06-10 16:00:29 EDT 
Verified on Mac OS 10.3.3 using I20040529.
Comment 22 Ines Khelifi CLA 2004-06-10 16:41:10 EDT 
Adding Kim so that she can mark this bug as verified.
Comment 23 Kim Horne CLA 2004-06-10 16:52:07 EDT 
Marking as verified on your behalf.
Comment 24 Bryan Hunt CLA 2004-06-15 20:50:14 EDT 
I'm still seeing this problem on RC2 using the Properties view to edit a Text field.  The text gets cut off 
at the bottom of the field.
Comment 25 Andre Weinand CLA 2004-06-24 04:40:55 EDT 
This bug report (and its fix) is only for the Navigator.
[I've updated title accordingly]

Please file a new bug against the Properties view.