Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 384116 - SAP HANA Database doesn't support scrollable cursors - adapt tests
Summary: SAP HANA Database doesn't support scrollable cursors - adapt tests
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Server 2008
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard: submitted_patch
Keywords:
Depends on:
Blocks: 383862
  Show dependency tree
 
Reported: 2012-07-03 04:50 EDT by Sabine Heider CLA
Modified: 2022-06-09 10:21 EDT (History)
1 user (show)

See Also:

Attachments
Patch containing the test changes (9.68 KB, patch)
2012-07-03 05:01 EDT, Sabine Heider CLA 		no flags Details | Diff
More test cases adapted (6.73 KB, patch)
2012-12-12 07:44 EST, Sabine Heider CLA 		tom.ware: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sabine Heider CLA 2012-07-03 04:50:23 EDT 
SAP HANA Database doesn't support scrollable cursors. To be precise, only the result set type TYPE_FORWARD_ONLY with concurrency mode CONCUR_READ_ONLY are supported.
Tests that rely on scrollable cursors should therefore be skipped for that database platform. These are:

- org.eclipse.persistence.testing.tests.queries.Jdk12ScrollableCursorTest
- org.eclipse.persistence.testing.tests.queries.ScrollableCursorAPITest
- org.eclipse.persistence.testing.tests.queries.ScrollableCursorBackwardReadingTest
- org.eclipse.persistence.testing.tests.queries.ScrollableCursorJoinedAttributeTest
- org.eclipse.persistence.testing.tests.queries.ScrollableCursorJoiningVerificationTest
- org.eclipse.persistence.testing.tests.queries.ScrollableCursorNavigationAPITest
- org.eclipse.persistence.testing.tests.queries.ScrollableCursorStatementCachingReadTest
- org.eclipse.persistence.testing.tests.queries.ScrollableCursorTest

The test 
- org.eclipse.persistence.testing.tests.queries.options.ClearQueryOptionsOnStatementTest 
is adapted so that is uses TYPE_FORWARD_ONLY and CONCUR_READ_ONLY on SAP HANA Database.

I'll attach a patch containing the changes.
Comment 1 Sabine Heider CLA 2012-07-03 05:01:45 EDT 
Created attachment 218201 [details]
Patch containing the test changes
Comment 2 Tom Ware CLA 2012-07-05 10:47:52 EDT 
Checked in changes as submitted

Reviewed by Tom Ware - reviewed user -submitted changes
Comment 3 Sabine Heider CLA 2012-12-12 07:43:12 EST 
I encountered a few more instances of the same issue. I fixed the problem in the same manner by making sure that the tests always use TYPE_FORWARD_ONLY and CONCUR_READ_ONLY when executed on SAP HANA database. See attached patch.
Comment 4 Sabine Heider CLA 2012-12-12 07:44:11 EST 
Created attachment 224626 [details]
More test cases adapted
Comment 5 Sabine Heider CLA 2013-01-08 07:05:41 EST 
I made this change a github contribution and created a pull request for it:
https://github.com/sabineheider/eclipselink.runtime/commit/af8c62efd49dfce3b732ce3f5e73d2fbaf360439

I hope that makes it easier to handle. Please let me know if I made anything wrong - I'm not yet familiar with the github contribution process.
Comment 6 Tom Ware CLA 2013-01-10 15:17:03 EST 
Checked in changes.

reviewed by: Tom Ware - reviewed submitted changes

Tested with Core and JPA LRG
Comment 7 Eclipse Webmaster CLA 2022-06-09 10:21:30 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink