This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 384108 - JUnit view icon no longer shows progress while executing tests
Summary: JUnit view icon no longer shows progress while executing tests
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.4 M5   Edit
Assignee: Daniel Rolka CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 148574 (view as bug list)
Depends on: 378408
Blocks:
  Show dependency tree
 
Reported: 2012-07-03 03:39 EDT by Aviv Ben-Yosef CLA
Modified: 2014-02-06 06:29 EST (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aviv Ben-Yosef CLA 2012-07-03 03:39:25 EDT 
Build Identifier: Version: Juno Release Build id: 20120614-1722

Before I upgraded to Juno this morning I used to happily run tests with the JUnit view minimized, and enjoy seeing the progress of the tests on it. Now I don't see any change on the icon until if passes (where a green check appears) or fails (where a red X appears).

The animation of the little green/red squares, showing progress of the suite is gone, which is very frustrating and means I have to waste screen real estate having the junit view open (not optimal at all when coding on a small screen).

Reproducible: Always

Steps to Reproduce:
1. Open Juno
2. Run JUnit test
3. See no progress
Comment 1 Dani Megert CLA 2012-07-03 10:08:39 EDT 
It looks like the fix for bug 318866 is not complete: that fix only works if the JUnit view did not have focus when the stack got minimized.

This should be considered for 4.2.1.
Comment 2 Eric Moffatt CLA 2013-08-20 16:00:58 EDT 
The problem is that the act of minimizing a stack and subsequently showing / hiding it currently do not issue the part

There is currently no API we can use to issue the events from the MinMaxAddon since that would require the addon having a dependency on the IDE (and it's heavily used in e4 apps).

We're currently working on a much better state machine based manager for part states in e4 (see bug 378408) and once it's done we'll be able to proceed with fixing this one (we expect to put a 'setPartState' API into the EPartService as part of this work).
Comment 3 Daniel Rolka CLA 2013-08-21 03:19:57 EDT 
Some prerequisites are missing to fix it now. See Comment 2
Comment 4 Daniel Rolka CLA 2013-11-25 10:53:03 EST 
(In reply to Daniel Rolka from comment #3)
> Some prerequisites are missing to fix it now. See Comment 2

I see that the Bug378408 is still in the 'New' state. Should we wait for it or we can try to implement it using different approach if possible (i.e. using some model tags)?

Daniel
Comment 5 Paul Webster CLA 2013-11-28 12:08:41 EST 
Eric, should we try and fix this or defer it to M5 and fix it with the lifecycle handling?

PW
Comment 6 Daniel Rolka CLA 2014-01-14 10:02:17 EST 
The patch proposal has been pushed to Gerrit - https://git.eclipse.org/r/#/c/20615/

thanks,
Daniel
Comment 7 Eric Moffatt CLA 2014-01-17 09:41:23 EST 
Pushed Daniel's last patch:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5da5952ac820ee036bf94b225389c550c9fd6e35

Thanks dude !
Comment 8 Dani Megert CLA 2014-01-20 06:23:13 EST 
Verified in I20140119-2000.
Comment 9 Daniel Rolka CLA 2014-02-06 06:29:14 EST 
*** Bug 148574 has been marked as a duplicate of this bug. ***