Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 384056 - Disabled icons not being used from extension definition
Summary: Disabled icons not being used from extension definition
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.3 M6   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard: patch
Keywords:
: 398392 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-07-02 11:09 EDT by Julia Perdigueiro CLA
Modified: 2013-03-14 16:33 EDT (History)
4 users (show)

See Also:

Attachments
proposed patch (3.03 KB, patch)
2013-01-09 03:29 EST, Christian Walther CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julia Perdigueiro CLA 2012-07-02 11:09:17 EDT 
I have declared a toolbar menu contribution command, and the "disabledIcon" property does not seem to be respected. I even tried the org.eclipse.ui.commandImages extension point to verify if the "disabledIcon" from that extension (and not org.eclipse.ui.menus) would be respected, but still no success.

What I get on my GUI is the automatically generated version of my disabled icons, which for some images do not look good so I had generated them myself. While running on top of Eclipse 3.7.2 everything looked fine, but now I cannot get it to work.
Comment 1 Jesper Eskilson CLA 2012-10-16 04:46:22 EDT 
I have the same problem. The "disabledIcon" attribute in my toolbar menu contribution is ignored, and a grey square is displayed instead.
Comment 2 Christian Walther CLA 2013-01-09 03:29:07 EST 
Created attachment 225367 [details]
proposed patch

Confirmed. The attached patch appears to fix it.
Comment 3 Paul Webster CLA 2013-01-17 10:02:32 EST 
*** Bug 398392 has been marked as a duplicate of this bug. ***
Comment 5 Christian Walther CLA 2013-02-12 11:07:30 EST 
Thanks!
Comment 6 Daniel Rolka CLA 2013-03-14 16:23:20 EDT 
Verified in the build: I20130311-2000-win32-x86_64