Community
Participate
Working Groups
Created attachment 217049 [details] screenshot The "clone repository" item in "create new content" is actually a link to the repo page, so it looks different than the other items in this list. The intention is that this button would actually perform the clone while staying on the navigator page but that would require bug 378755. If that bug gets implemented in RC2, then we can just update the command and it will look normal. If we don't get to it, we need to show this link differently, perhaps remove it from the list completely and just have text at the bottom that talks about cloning and has a link.
Looks like bug 378755 is going to happen. Still to consider: - should we move "clone" up in the list? Seems like it's at least more common than "Upload a Zip" and perhaps more common than "SFTP Import" - the styling was dealing with the fact that we had mixed buttons and links, and was done when all the buttons were bolded. Now that the tasks are all buttons, we can return to normal command styling, I think, and then if we want to tweak it further we could...
Also, we should put it in the "new" menu. It was not there before because it was a link. See bug 382193.
Simon does not want us to put a hard reference to a git module in the navigator. So we need another answer here. The thinking is to restyle everything like command buttons, do not differentiate git clone by its look.
(In reply to comment #3) > Simon does not want us to put a hard reference to a git module in the > navigator. So we need another answer here. The thinking is to restyle > everything like command buttons, do not differentiate git clone by its look. THe problem with this approach is then...does this button open a new page or change the existing one. Either approach seems surprising. Why don't we take the approach of removing it from the list and then have a real link.
Created attachment 217316 [details] screenshot/mockup
So as I see it...three choices: 1) make the link look like a button, it opens repo page in same tab. Pro: don't make user think about the difference, don't surprise them with a new page since it's a button. Con: disorienting. How do I get back to the navigator. 2) make the link look like a button, open repo page in new tab. Pro: don't make user think about difference Con: still disorienting, but they know how to get back to navigator 3) pull the link out of the list and style it as shown in the mockup. Treat it different because it is. Explain to the user that they can clone but need to go to another page to do so. Just use good ol' HTML to do it.
After various discussions with Simon, Ken, Anton...the consensus is #1. We decided that some disorientation is going to happen regardless of the solution. #3 subtly says "you are about to be disoriented" which isn't that helpful. #2 is very disorienting from a browser tab point of view. #1 is disorienting but after trying it out, the "how do I get back to navigator" problem is somewhat rectified by the appearance of the "show in navigator" link. I was worried we were relying on the user to use browser history or the top level link. Commit 0dc9722adf17dcc7038039c8b49abf983e835268 in the bug 382047 branch implements #1. It tested it and it works. But I found a new problem in the workflow. It works great if you have repositories already. But in the "new user" workflow, the user has no repositories and in that setup, the command slideout does not open. So we still need to fix the page so that the slideout opens even when the repo is empty. I don't think I'll get to this today. Marking this bug for review by Szymon (the UI is already OK'ed by everyone else). If you approve and have a chance to fix teh "empty repo page problem" please release another commit to the branch, send it back to me for review, and I can release if all is well.
(In reply to comment #7) > If you approve and have a chance to fix teh "empty repo page problem" > please release another commit to the branch, send it back to me for review, and > I can release if all is well. Done.
Thank you! I would not have figured that one out based on looking at the change. Pushed both commits. Tested with "empty" user. The repo page comes up nice and fast, the slideout is there. Noticed bug 382604 but agree this is not critical.
