Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 381753 - [sites] Mappings section on Edit Site page is too easy to collapse
Summary: [sites] Mappings section on Edit Site page is too easy to collapse
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 RC1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-05 13:26 EDT by Mark Macdonald CLA
Modified: 2012-06-07 12:56 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2012-06-05 13:26:47 EDT 
I like the appearance of the "Mappings" section on the Edit Site page. However, I keep accidentally collapsing it by clicking the header when I'm aiming for the "Add" button.

Perhaps it should be non-collapsible. I wonder if anyone else has noticed this.
Comment 1 Szymon Brandys CLA 2012-06-06 07:03:32 EDT 
I think it is more general question about how to collapse sections. So far you have to click anywhere at the section header (excluding action bar) to collapse/expand it.
Comment 2 Mark Macdonald CLA 2012-06-06 16:10:58 EDT 
(In reply to comment #1)
> I think it is more general question about how to collapse sections. So far you
> have to click anywhere at the section header (excluding action bar) to
> collapse/expand it.

Maybe we can restrict the expand/collapse hit zone to the section name and the twistie. Clicking the blank space on the section header would do nothing...
Comment 3 Susan McCourt CLA 2012-06-07 12:56:46 EDT 
Fixed in
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ba061d4be5449e89658584ba6b649bcf94086aed

as suggested by Mark.

We were already checking/responding to hits on the header dom node, title, and twistie, so I just removed the condition to trigger on a hit of the containing header.