Community
Participate
Working Groups
If you open up all the tags for, say, the orion client you will see many. If you click on the checkout icon you get a dialog with the tag name and then a text entry field. There should be more descriptive text as to what you are entering. I think it's the local branch name but not sure. If it is, the text entry field could be populated with the tag name perhaps.
Patch may be found on: https://github.com/maciej-bendkowski/orion.client/commit/c98bbbb9ef362c19832549f3b338ccffea5d7e93 I(In reply to comment #0) > I think it's the local branch name but not sure. If it is, the text > entry field could be populated with the tag name perhaps. Done as requested. Now the input field has a description "Local Branch Name:", and is prompted with the tag name (with an appropriate "tag_" prefix). Formal Note: I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
I think we should use command prompter aka ParametersDescription. See gitCommands.js#addTagCommand around line 1559.
(In reply to comment #2) > I think we should use command prompter aka ParametersDescription. See > gitCommands.js#addTagCommand around line 1559. Fix: https://github.com/maciej-bendkowski/orion.client/commit/e6a1651cf9c17ea2a37bd80ca4973056bb3e5c50 Now the checkoutTagCommand is using ParametersDescription as well as the previous getNewItemNameWithPrompt. This is almost the same solution as in the addTagCommand. Formal Note: I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
I would remove the prompt (getNewItemNameWithPrompt) from the code. If the branch name is empty. clicking 'Submit' should do nothing. When we have validators added (see bug 380512), we could mark the field somehow to indicate that something should be entered.
(In reply to comment #4) > I would remove the prompt (getNewItemNameWithPrompt) from the code. If the > branch name is empty. clicking 'Submit' should do nothing. When we have > validators added (see bug 380512), we could mark the field somehow to indicate > that something should be entered. Fix: https://github.com/maciej-bendkowski/orion.client/commit/a426a09176d4d73b12f544b64f73f2b00c9251c3 Done as requested.
Please merge commits and push to the branch on github again.
(In reply to comment #6) > Please merge commits and push to the branch on github again. Done. Fixed with e1dec40449882d8dee90023de0cdff50ff64ce12.
