Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 381611 - [settings][plugins] - move to selection model and toolbar actions
Summary: [settings][plugins] - move to selection model and toolbar actions
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.0 M1   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 367458
  Show dependency tree
 
Reported: 2012-06-04 13:10 EDT by Susan McCourt CLA
Modified: 2013-04-01 22:54 EDT (History)
2 users (show)

See Also:

Attachments
screenshot (113.22 KB, image/png)
2013-02-11 15:36 EST, Mark Macdonald CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-06-04 13:10:13 EDT 
In bug 367458 we are beginning to move infrequently used actions from the
inline commands to an Actions menu in the toolbar that operates on the
selections.

This bug tracks moving the plugins page to this approach.

Note that this page also needs to use the common selection model in order to get the cursor/navigation behavior of the other pages.  Not sure that we'll get to this in 0.5.
Comment 1 Anton McConville CLA 2012-06-04 13:18:43 EDT 
So there is no choice in this? All items are selection model with no inline action? The plugins entries were designed to carry more content than a single line.
Comment 2 Susan McCourt CLA 2012-06-04 16:54:39 EDT 
(In reply to comment #1)
> So there is no choice in this? All items are selection model with no inline
> action? The plugins entries were designed to carry more content than a single
> line.

The current thinking is single default action, with scroll spy/pinning to help keep section toolbars in view, and the "floating" actions on single select.  but we won't get to implement all that in time for 0.5, so this bug just tracks which pages still need to be visited later.  The solution could certainly evolve by the time we get to this.  

See 367458 and its dependents for the ideas...
Comment 3 Mark Macdonald CLA 2013-02-11 15:35:42 EST 
I have a patch that converts the plugin list to the selection model. I wasn't able to finish the toolbar actions for 2.0RC1, and I figured just releasing the selection model alone might be inconsistent with the rest of the UI, so I decided to wait on this.

The patch is here
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=mark/plugin_selection
Comment 4 Mark Macdonald CLA 2013-02-11 15:36:36 EST 
Created attachment 226872 [details]
screenshot

Selection model without toolbar actions looks like this
Comment 5 Mark Macdonald CLA 2013-04-01 12:33:07 EDT 
Since the plugin list is so tall, a scroll spy is needed to make toolbar actions usable. Commands that act on one or more plugins from the list need to be near the items that they act upon.

However, I do like the selection list behavior for navigating the plugin list. It's also more consistent in appearance with the rest of our UI. I'll push the change, but keep this bug open for moving to the selection model + toolbar actions + scrollspy (someday that will happen, I hope).
Comment 6 Mark Macdonald CLA 2013-04-01 12:33:36 EDT 
(In reply to comment #5)
Here is the change to use a selection list:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=16d0964c741c598726e7ab95
Comment 7 Susan McCourt CLA 2013-04-01 22:19:47 EDT 
If you pushed the change you can probably just close this bug and someday someone will work on bug 380454.
Comment 8 Mark Macdonald CLA 2013-04-01 22:54:28 EDT 
(In reply to comment #7)
> If you pushed the change you can probably just close this bug and someday
> someone will work on bug 380454.

Sounds good, let's do it