Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 381134 - Mixed line delimiters in /org.eclipse.jdt.compiler.apt/customBuildCallbacks.xml
Summary: Mixed line delimiters in /org.eclipse.jdt.compiler.apt/customBuildCallbacks.xml
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: APT (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.3 M4   Edit
Assignee: Jay Arthanareeswaran CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-31 02:47 EDT by Dani Megert CLA
Modified: 2012-11-15 08:19 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2012-05-31 02:47:09 EDT 
master

Mixed line delimiters in /org.eclipse.jdt.compiler.apt/customBuildCallbacks.xml
Comment 1 Walter Harley CLA 2012-05-31 03:22:15 EDT 
Hmm, has anybody even touched that since 3.2?
Comment 2 Dani Megert CLA 2012-05-31 03:26:13 EDT 
This probably got added by the copyright tool in May 2010 and can wait to be fixed in the next cycle.
Comment 3 Dani Megert CLA 2012-11-13 08:35:40 EST 
Jay, please fix this. Thanks.
Comment 4 Jay Arthanareeswaran CLA 2012-11-14 23:58:19 EST 
(In reply to comment #3)
> Jay, please fix this. Thanks.

Did you mean the carriage return on the first line? If so, this one has it too:
org.eclipse.jdt.compiler.tool/customBuildCallbacks.xml

I will fix them both.
Comment 5 Dani Megert CLA 2012-11-15 04:04:38 EST 
(In reply to comment #4)
> (In reply to comment #3)
> > Jay, please fix this. Thanks.
> 
> Did you mean the carriage return on the first line? If so, this one has it
> too:
> org.eclipse.jdt.compiler.tool/customBuildCallbacks.xml
> 
> I will fix them both.

Yes, thanks.
Comment 7 Dani Megert CLA 2012-11-15 06:49:33 EST 
You also have to update the bundle version.
Comment 8 Jay Arthanareeswaran CLA 2012-11-15 08:16:18 EST 
(In reply to comment #7)
> You also have to update the bundle version.

Done, it's here:
http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=96141a500917c1125f3f9ae76a90d146f8031558
Comment 9 Dani Megert CLA 2012-11-15 08:19:45 EST 
Thanks