Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 379611 - explorer "action scope id" should not default to known scope
Summary: explorer "action scope id" should not default to known scope
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 367458
Blocks:
  Show dependency tree
 
Reported: 2012-05-15 17:13 EDT by Susan McCourt CLA
Modified: 2012-05-16 18:03 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-05-15 17:13:05 EDT
The navigator currently defaults its "action scope id" to "itemLevelCommands".  this was a way to change the command contribution mechanism late in 0.4 without impacting too many clients.

but in light of bug 367458 we have a lot less item level commands.  Once all of this settles out, we need to revisit the navigator.  There's no reason the navigator should be calling the command service to render item level commands if there aren't any contributed.  It doesn't cost much time to realize that there are no commands to render, but it make debugging more difficult.

We could prevent this by simply having the explorer not render commands if an action scope id has not been supplied.   Need to check all the places where pages are relying on "itemLevelCommands" but should do this after bug 367458
Comment 1 Susan McCourt CLA 2012-05-16 18:03:16 EDT
Fixed.
The navigator was the only place relying on a hard-coded "action scope id."  Changed the common renderers to not try to render unless there is a scope id specified, and the navigator no longer specifies one.

The other pages are specifying the scope id's either in the glue code or in the rendering widget.  These will be addressed case by case in bug 367548.

A client now has to specify explicitly that it needs to render item level commands by putting an actionScopeId in the explorer options.