Comment 1 Robert Krajewski 2012-05-07 13:28:35 EDT

Just for reference, is there a list of minimal dependencies?

Comment 2 Steffen Pingel 2012-05-07 16:38:21 EDT

This is the list of dependencies:

 org.eclipse.core.runtime,
 org.eclipse.ui,
 org.eclipse.ui.forms,
 org.eclipse.mylyn.commons.core;bundle-version="3.7.0",
 org.eclipse.mylyn.commons.screenshots;bundle-version="1.0.0"
 
In regard to notifications you will also need to modify the manifest of o.e.m.commons.workbench to remove the o.e.ui.ide dependency by making these dependencies optional:

 org.eclipse.ui.browser;resolution:=optional,
 org.eclipse.ui.editors;resolution:=optional,

It sounds like we should split the o.e.m.commons.workbench bundle further and create an o.e.m.commons.ide bundle that moves classes that depend on the packages above. Would any of the remaining dependencies be problematic for you?

 org.eclipse.core.runtime,
 org.eclipse.core.expressions,
 org.eclipse.jface,
 org.eclipse.jface.text,
 org.eclipse.ui,
 org.eclipse.ui.forms,
 org.eclipse.ui.workbench,
 org.eclipse.ui.workbench.texteditor,

Comment 3 Eddie Galvez 2012-05-07 16:42:16 EDT

(In reply to comment #2)
> Would any of the remaining dependencies be problematic for you?
> 
>  org.eclipse.core.runtime,
>  org.eclipse.core.expressions,
>  org.eclipse.jface,
>  org.eclipse.jface.text,
>  org.eclipse.ui,
>  org.eclipse.ui.forms,
>  org.eclipse.ui.workbench,
>  org.eclipse.ui.workbench.texteditor,


no, no issues there. Think of just supporting standard RCP away from the IDE that's all, nothing special. workbench and texteditor are OK (they do not force UI contributions that are problematic for a non-IDE)

Comment 4 Steffen Pingel 2012-05-08 11:13:57 EDT

Thanks. I just realized that we already exported the classes as API in the last release and hence can't easily split the bundle. I decided to go with the changes described in comment #2.

Comment 5 Steffen Pingel 2012-05-08 11:14:00 EDT

Created attachment 215269 [details]
mylyn/context/zip

Comment 6 Eddie Galvez 2012-05-08 12:18:52 EDT

Steffen, just to be crystal clear (and because there might have been a plug-in that you listed that is OK in RCP apps).

o.e.mylyn.commons.ui:
 should mark ui.editors as optional. all others are OK for RCP apps (even ui.browser)

o.e.mylyn.commons.workbench:
 same: mark ui.editors as optional.


So the refinement here that I think might contradict the patch you've completed, is to leave ui.browser alone.

Comment 7 Steffen Pingel 2012-05-08 13:12:59 EDT

(In reply to comment #6)
> So the refinement here that I think might contradict the patch you've completed,
> is to leave ui.browser alone.

I was debating that. I ended up marking it as optional since that was the case prior to 3.7 and it's seemed likely enough that somebody would make a case to reuse the bundle without bringing in the browser support.