Community
Participate
Working Groups
Build Identifier: I20110620-1631 If I create a PartStack that contains multiple parts but none of the parts are closeable, when I right click on any of the tabs I get menu options for "Close All" and "Close Others". Selection of either of the menu options doesn't cause any tabs to be closed since none of the tabs can be closed. I don't think the menu options should be available if none of the tabs can be closed. I am attaching a patch that will prevent Reproducible: Always Steps to Reproduce: 1. Create PartStack that contains multiple parts 2. Make sure none of the parts in the stack are marked as closeable. 3. Right click on any of the tabs. A menu will be displayed even though none of the tabs can be closed.
Created attachment 215089 [details] Patch that makes sure there are closeable sibling parts before adding Close All and Close Others options
Correcting platform
Sarah, good pickup ! However, your patch contains changes in to Workbench.java that appear to have no bearing on this defect...was this accidental ? If so could you update the patch based on the current source for StackRenderer ? I was going to apply it 'by hand' but I'm afraid of messing it up :-).
Created attachment 223276 [details] Requested patch that does not have workbench changes using latest code Here is the requested patch
Sarah, thanks for the quick response. I'll be committing the patch (thanks again!) since it's certainly better than what's there. There was one thing I had to fix in the getCloseableSiblingParts...the handling for MPlaceholders didn't check the placeholder itself to see if it was 'toBeRendered', leading to issues in the eclipse IDE. Other than that it looks really good.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3ca8456b51ad639447cf86250747e9c05ac972e6 Thanks Sarah... It still has a glitch or two though, mostly in mixed stacks with some closeable and some not but it does cover off the case you've defined as we as being better overall. I'll mark this defect as fixed since it does address the 'all non-closeable' case nicely.
*** Bug 394443 has been marked as a duplicate of this bug. ***
Not sure if changing the milestone to 4.4 was on purpose or by accident. If this still requires additional work, I suggest cloning it.
Curtis, are the 'glitches' I mentioned in Comment #6 no longer valid ? I was presuming that there were cases still left unhandled based on that comment (but I'd love to be wrong...;-). If everything is working then we should be marking this as VERIFIED...
(In reply to comment #9) > Curtis, are the 'glitches' I mentioned in Comment #6 no longer valid ? I was > presuming that there were cases still left unhandled based on that comment > (but I'd love to be wrong...;-). > > If everything is working then we should be marking this as VERIFIED... No idea, but the bug was fixed in M4. Marking the bug as 4.3.1 without even reopening isn't the right move :) If the glitches warrant a 4.3.1 bug then a new bug report should be opened.
