Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 378120 - right-side toolbar in eclipse's top banner appears to contain two toolbars
Summary: right-side toolbar in eclipse's top banner appears to contain two toolbars
Status: CLOSED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.8   Edit
Hardware: PC Linux-GTK
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Arun Thondapu CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 392053 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-04-30 16:54 EDT by Grant Gayed CLA
Modified: 2019-01-18 13:42 EST (History)
7 users (show)

See Also:


Attachments
screenshot (15.11 KB, image/jpeg)
2012-04-30 16:54 EDT, Grant Gayed CLA
no flags Details
Appearance on Windows 7 32bit, without Chevron button (141.70 KB, image/png)
2012-05-21 09:32 EDT, Alexander Wessel CLA
no flags Details
Appearance on Windows 7 32bit, with Chevron button (93.91 KB, image/png)
2012-05-21 09:33 EDT, Alexander Wessel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Gayed CLA 2012-04-30 16:54:43 EDT
Created attachment 214838 [details]
screenshot

- using 3.8M7 test build: I20120429-1800

- open a few perspectives
- drag the banner's separator to the right, to squeeze the tool buttons with the perspective names, and force the ToolBar's overflow menu button to be shown
- the overflow menu button is shown, but so is another unexpected button whose image looks like a quotation mark (screenshot is attached)
  - pressing this button shows the same tool item as the overflow drop-down
- SWT Spy indicates that this is a different ToolBar instance from the one to its left that contains the tool items and overflow button, so presumably it is being created by UI (?)
Comment 1 Paul Webster CLA 2012-04-30 17:19:39 EDT
(In reply to comment #0)
> Created attachment 214838 [details]
> screenshot
> 
> - using 3.8M7 test build: I20120429-1800
> 

Did you mean I20120429-2000 ?

the 1800 build was a 4.2 build

PW
Comment 2 Grant Gayed CLA 2012-05-01 10:02:51 EDT
Yes, the 3.8-stream build, thanks.
Comment 3 Grant Gayed CLA 2012-05-04 12:08:37 EDT
I spent some time investigating this, and this appears to be an SWT issue, so taking report back.

The second ToolBar is created by CoolItem.updateChevron() for displaying the chevron when it has become too narrow to show all of its items (the button with the "quote mark" is the chevron, I'm not sure why it is looking like this).

Since the ToolBar in the CoolItem has style SWT.WRAP, it is correctly showing its own drop-down arrow, but the CoolItem's chevron should only need to be shown when the ToolBar has become too narrow to show its drop-down button.  My guess is that when the ToolBar is showing its drop-down button it may be reporting too large a size (or too large a preferred size), which is causing the ToolBar with the chevron to be created/shown when it's not actually needed.
Comment 4 Grant Gayed CLA 2012-05-04 13:08:21 EDT
Arun can you investigate this for 3.8RC1?  It's visually quite obvious, and if not fixed now will be re-logged many times after the release.
Comment 5 Alexander Wessel CLA 2012-05-21 09:32:33 EDT
Created attachment 215957 [details]
Appearance on Windows 7 32bit, without Chevron button

For reference, I added the appearance in Windows. To clarify, the extra toolbar also appears if the chevron button is _not_ displayed.
Comment 6 Alexander Wessel CLA 2012-05-21 09:33:33 EDT
Created attachment 215960 [details]
Appearance on Windows 7 32bit, with Chevron button
Comment 7 Arun Thondapu CLA 2012-10-16 08:37:37 EDT
*** Bug 392053 has been marked as a duplicate of this bug. ***
Comment 8 Xi Yan CLA 2018-12-19 10:13:11 EST
I cannot reproduce this in I20181206-0815. The perspective toolbar doesn't show any overflow buttons and just moves to the next row when it is overflown. Is this still relevant?
Comment 9 Xi Yan CLA 2019-01-18 13:42:26 EST
No response in awhile, closing this ticket now. Please reopen it if you still
experience the issue on GTK3.22+ and SWT 4.10.