Community
Participate
Working Groups
If you click "View All Tags" in the git repositories view, you get a page of all tags in the repository. The URL says &page=1, however the result is not paginated. In the Orion Server case I get back about 1000 tags. Debugging this on the server, I case ListTagsJob gets created and run twice. The first time has a page size of 50, the second time has a page size of -1 (meaning get everything). Maybe we should in fact default to size 50 on the server if the client doesn't specify.
As I recall there was the default size set to 50, if not specified. At least we had this for git log and maybe was not propagated to tags and branches.
(In reply to comment #1) > As I recall there was the default size set to 50, if not specified. At least we > had this for git log and maybe was not propagated to tags and branches. That is correct. Git log is the only place where pagination has been effectively introduced. I guess "&page=1" John saw for listing tags is bogus.
Fix: https://github.com/maciej-bendkowski/orion.client/commit/f9688b5c7a8e54c3ca5031efe484fdbfadf05bac This pagination pattern touches the future repository UI idea I've mentioned in bug 369604.
(In reply to comment #3) > Fix: > https://github.com/maciej-bendkowski/orion.client/commit/f9688b5c7a8e54c3ca5031efe484fdbfadf05bac > gitCommands.js is shown as if every single line was changed. Unfortunately it's also conflicting with newest master version, so it's really hard to review it.
(In reply to comment #4) > gitCommands.js is shown as if every single line was changed. Unfortunately > it's also conflicting with newest master version, so it's really hard to > review it. Indeed. Please try this one: https://github.com/maciej-bendkowski/orion.client/commit/9b5b82e5b9321b4912fa064cd341fe27a2a2ef49
(In reply to comment #5) > Indeed. Please try this one: > https://github.com/maciej-bendkowski/orion.client/commit/ > 9b5b82e5b9321b4912fa064cd341fe27a2a2ef49 Better, thanks. 1. line 182 "that.redisplaynavigator" should be "that.redisplayNavigator" 2. I don't understand why you call redisplayNavigator always in displayRepository and only when you render Tags you call it in displayTags.
The ideal solution here would be: 1. When we hit "View All" for tags we are redirected to a site that has hash: /gitapi/tag/file/a/?page=1, this is the first page of the list of tags in "/file/a" repository, the list does not contain details 2. Because we already have the list of tags we can render information based on it: tag name, actions 3. Each tag has CommitLocation field, if we request for tag.CommitLocation + "?page=1&pageSize=1", we'll get the last commit tagged with this tag, we can use this information to render the rest of the details 4. For dynamically rendering details we can use the same mechanism that we used for dynamic loading the repositories
Fix: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_58234240ff4ccd4f8da152392f707ab0f7063f53 Szymon, please review for Gosia.
Commit merged to master.
