Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 377912 - Orion Greasemonkey scripts should allow to work with any Orion instance not just OrionHub
Summary: Orion Greasemonkey scripts should allow to work with any Orion instance not j...
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 RC1   Edit
Assignee: Edyta Przymus CLA
QA Contact:
URL:
Whiteboard: gsoc2012
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-27 09:49 EDT by Szymon Brandys CLA
Modified: 2012-07-10 08:34 EDT (History)
1 user (show)

See Also:


Attachments
Switch Branch dialog (32.49 KB, image/png)
2012-05-21 11:40 EDT, Szymon Brandys CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2012-04-27 09:49:08 EDT
All our Greasemonkey scripts work just with orionhub.org at the moment. So if you have the script for GitHub installed, you can clone GitHub repos just to OrionHub. Would be good if I could select Orion instance before cloning or opening a commit. I think we should allow to select orionhub.org, orion.eclipse.org or allow to enter the address of other Orion instances.
Comment 1 Szymon Brandys CLA 2012-05-21 11:37:11 EDT
Some comments to https://github.com/edytaprzymus/orion.client/commit/a144f4d70e67d61710960060bfa4a734c7dbb366

1. When I tried to clone into my own Orion instance on localhost, it opens http://localhost:8080/git/git-repository.html#,cloneGitRepository=
There should be clone repo address there

2. "Clone into OrionHub" and "Clone into orion.eclipes.org" should behave like buttons. When I hover them now nothing happens.

3. There is no need to have a separate field for host and port. Once you choose an option, the dialog should be closed. The current version does not close when I select something.

4. There should be a close button in the corner, to close the dialog if you decided to cancel.
Comment 2 Szymon Brandys CLA 2012-05-21 11:40:51 EDT
Created attachment 215978 [details]
Switch Branch dialog

Moreover the option to clone into your own server should be "Clone into [input field]" in one line, not "Clone into your own server" with two input fields below
Comment 3 Szymon Brandys CLA 2012-05-21 11:51:41 EDT
You can also consider the following dialog look:

Clone Repository into <----- header like on the branch dialog with close button
-----------------------
OrionHub
orion.eclipse.org
[input dialog]

In general, see other GitHub dialogs and make our dialog similar. Moreover I would lilke to see updated scripts for git.eclipse.org and Eclipse Bugzilla.
Comment 4 Edyta Przymus CLA 2012-05-21 16:24:34 EDT
Hi, this is my commit with all scripts improved:

https://github.com/edytaprzymus/orion.client/commit/8ddab493e64781f62f5f8db40ccb1acbb9bb1454
Comment 5 Szymon Brandys CLA 2012-05-25 09:39:04 EDT
Moving to RC1

I chatted with Edyta what would be the right wording and presentation on GitHub, git.eclipse.org and Bugzila. This is what we agreed for.

== GitHub ==

The popup dialog should say
Clone Repository Into
OrionHub
orion.eclipse.org
other Orion at [input]

Edyta, make sure that you can navigate in the popup using keyboard. Enter and arrows do not work there in your latest commit.

== git.eclipse.org ==

Clone into Orion

Select the Orion instance
[ ] OrionHub  [ ] orion.eclipse.org  [ ] other Orion at [input]

and click one of the links below to clone
git://git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git
ssh://git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git
http://git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git

== Bugzilla ==

We will have a separate section between bug details and attachments. It would look like that.

Work with the bug in Orion

Select the Orion instance
[ ] OrionHub  [ ] orion.eclipse.org  [ ] other Orion at [input]

and click the link below to clone
[repo url]
Comment 7 Szymon Brandys CLA 2012-05-29 09:45:10 EDT
Fixed with 660ec5ca577a5fef498f124a9bca6eb4c1173f08. Thanks Edyta!
Comment 8 Edyta Przymus CLA 2012-07-10 08:34:51 EDT
I wrote all this code and have the rights to contribute it to Eclipse under the
eclipse.org web site terms of use.