Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 377708 - [console] Mixed-case commands from org.eclipse.equinox.app not working anymore.
Summary: [console] Mixed-case commands from org.eclipse.equinox.app not working anymore.
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Components (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: Juno M7   Edit
Assignee: equinox.components-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-25 18:02 EDT by Sebastien Angers CLA
Modified: 2012-04-27 06:23 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastien Angers CLA 2012-04-25 18:02:51 EDT 
Build Identifier: I20120315-1300

Mixed-case console commands from org.eclipse.equinox.app Bundle are not working anymore with the adoption of Apache Felix Gogo console.

osgi> startApp xyz
gogo: IllegalArgumentException: Cannot find the command method for: _startapp

Other lowercase-only commands like “apps” are working just fine.

The issue comes from the fact that in org.apache.felix.gogo.runtime.Reflective.method(…), the Command Name is converted to lowercase.

So startApp will be converted to startapp and won’t be considered a valid command by org.eclipse.equinox.console.command.adapter.CommandProviderAdapter.findCommand(...)

Patch coming...


Reproducible: Always

Steps to Reproduce:
1. Launch the platform with Console required Bundles
2. osgi> startApp xyz
Comment 2 Thomas Watson CLA 2012-04-26 09:23:24 EDT 
I went ahead and committed the patch.  Thanks.  Lazar please review for correctness.  One side effect of this change is that all equinox commands are now case insensitive.
Comment 4 Sebastien Angers CLA 2012-04-26 09:35:58 EDT 
(In reply to comment #2)

Thanks Thomas for review & commit!
Comment 5 Lazar Kirchev CLA 2012-04-27 06:23:58 EDT 
(In reply to comment #2)
> I went ahead and committed the patch.  Thanks.  Lazar please review for
> correctness.  One side effect of this change is that all equinox commands are
> now case insensitive.

Patch is OK. Yes, gogo stores the command names all lowercase. So this patch is the only way to allow the mixed case command names.