Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 377656 - AbstractSequenceBox: Buttons should not be "label suffix candidates"
Summary: AbstractSequenceBox: Buttons should not be "label suffix candidates"
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Scout (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-25 11:45 EDT by Beat Schwarzentrub CLA
Modified: 2021-08-19 11:03 EDT (History)
3 users (show)

See Also:
claudio.guglielmo: juno+


Attachments
Proposed patch (1.79 KB, patch)
2012-04-25 11:45 EDT, Beat Schwarzentrub CLA
claudio.guglielmo: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beat Schwarzentrub CLA 2012-04-25 11:45:24 EDT
Build Identifier: 

PROBLEM:
If an SequenceBox contains a button (e.g. a link button), its label is duplicated:

Press me!          [ Press me! ]
    ^                   ^
Label of the        Button with
SequenceBox           label

EVALUATION:
The class AbstractSequenceBox offers the Method execIsLabelSuffixCandidate(IFormField) to control whether a field's label should be moved to the front label. The default implementation already excludes check boxes (IBooleanField). A check for IButton should be added. See attached patch.

WORKAROUND:
Implement the mentioned method yourself and return false when formField is an IButton.

Reproducible: Always
Comment 1 Beat Schwarzentrub CLA 2012-04-25 11:45:52 EDT
Created attachment 214539 [details]
Proposed patch
Comment 2 Claudio Guglielmo CLA 2012-05-23 03:16:25 EDT
Thank you Beat for the patch! It has been applied to 3.8.1.
Comment 3 Matthias Zimmermann CLA 2012-11-13 02:39:38 EST
shipped with scout juno sr1