Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 377642 - Problems with rendering compare widget commands in git-status section headers
Summary: Problems with rendering compare widget commands in git-status section headers
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 349328
  Show dependency tree
 
Reported: 2012-04-25 10:34 EDT by Szymon Brandys CLA
Modified: 2012-05-25 11:51 EDT (History)
2 users (show)

See Also:

Attachments
Illustration (3.99 KB, image/png)
2012-04-25 11:10 EDT, Szymon Brandys CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2012-04-25 10:34:41 EDT 
On git status and commit pages commands in section headers should be rendered as "button". Compare widget seems to always render its commands as "tool". There should be a way to render compare commands with the right style in section headers.
Comment 1 Szymon Brandys CLA 2012-04-25 11:08:37 EDT 
I looked at the issue with Libing. The problem is not the wrong style. He renders commands with "button" and they are just rendered wrong. See the screenshot.
Comment 2 Szymon Brandys CLA 2012-04-25 11:10:46 EDT 
Created attachment 214535 [details]
Illustration
Comment 3 Susan McCourt CLA 2012-04-25 12:14:14 EDT 
I'll take a look.  The symptom is certainly as if one were rendering by "tool" and we use bold when the icon is missing.
Comment 4 Szymon Brandys CLA 2012-05-11 06:57:56 EDT 
It seems that the problem disappeared.
Comment 5 Susan McCourt CLA 2012-05-25 11:51:36 EDT 
This surfaced again when I was removing all font face specifications from the CSS.  Some of the commands on section sidebars went bold.  The issue was that "sectionActions" didn't specify a font weight so it was getting bold from "sectionWrapper". 

I added the font weight to sectionActions and moved sectionActions and sectionAnchor from ide.css to sections.css.

Fixed in 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e7fe0124fb6b6540a0ee8de77fa30cf165c76b90