Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 377527 - Invalid contexts are misshandled in the getCapabilities command in the Breakpoints service
Summary: Invalid contexts are misshandled in the getCapabilities command in the Breakp...
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.0.0   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-24 10:52 EDT by Manuel Coutand CLA
Modified: 2013-06-05 05:42 EDT (History)
0 users

See Also:

Attachments
Proposed patch (6.98 KB, patch)
2012-04-24 10:53 EDT, Manuel Coutand CLA 		mober.at+eclipse: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Coutand CLA 2012-04-24 10:52:52 EDT 
Build Identifier: 

issuing a Breakpoints getCapabilities command with a invalid context doesn't result in an invalid context error at the moment.

We try to resolve the id using id2ctx() but since the id is invalid, the return ctx is NULL. We end up returning the general capabilities for the target.

Reproducible: Always
Comment 1 Manuel Coutand CLA 2012-04-24 10:53:28 EDT 
Created attachment 214468 [details]
Proposed patch

Here is a proposed patch for the bug.
Comment 2 Eugene Tarassov CLA 2012-04-25 11:08:54 EDT 
Committed the patch.
Thanks!
Comment 3 Martin Oberhuber CLA 2013-05-24 17:33:48 EDT 
Comment on attachment 214468 [details]
Proposed patch

iplog- since git has the author:

http://git.eclipse.org/c/tcf/org.eclipse.tcf.agent.git/commit/?id=877a0e5288e82afba356fbfa089da6a9e30fe77c