Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 377519 - [Workbench] PartServiceImpl#savePart() needs improvement
Summary: [Workbench] PartServiceImpl#savePart() needs improvement
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P4 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-24 10:02 EDT by Oleg Besedin CLA
Modified: 2014-03-25 06:29 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Besedin CLA 2012-04-24 10:02:34 EDT 
With the fix for the bug 372992 it becomes important for the EPartService to distinguish between "specific" requests to save a part and requests generated by closing modified part.

On a more general note, the implementation should mimic that of WorkbenchPage#closeEditors() which both does a few extra things comparing to the 4.x part service and is used by the command handler (both in 3.x and 4.x)

The structure of e4 compatibility layer will complicate this change as e4 service can't be made dependent on org.eclipse.ui.workbench. Hence, underlying functionality from WorkbenchPage#closeEditors() would need to be properly duplicated in e4 code.
Comment 1 Thomas Schindl CLA 2012-04-24 10:20:31 EDT 
What about the compat layer pushing a modified EPartService into the root-context?
Comment 2 Oleg Besedin CLA 2012-04-24 16:55:47 EDT 
(In reply to comment #1)
> What about the compat layer pushing a modified EPartService into the
> root-context?

That is a possibility. This will create a difference between how part service works in SDK and RCP, but that might be OK.
Comment 3 Lars Vogel CLA 2014-03-25 06:29:17 EDT 
AFAIK the current idea is to keep the core services simple. Marking as WONTFIX.