Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 377258 - Context queries consisting of only an empty string are misshandled
Summary: Context queries consisting of only an empty string are misshandled
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.0.0   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-20 05:24 EDT by Manuel Coutand CLA
Modified: 2013-06-05 05:42 EDT (History)
0 users

See Also:

Attachments
Proposed patch (784 bytes, patch)
2012-04-20 05:25 EDT, Manuel Coutand CLA 		no flags Details | Diff
Proposed patch v2 (1.09 KB, patch)
2012-04-20 05:51 EDT, Manuel Coutand CLA 		mober.at+eclipse: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Coutand CLA 2012-04-20 05:24:34 EDT 
Build Identifier: 

Last fix introduced a change in the way queries consisting only of an empty string are parsed. parse_context_query now returns -1 for such queries which is wrong.

Reproducible: Always
Comment 1 Manuel Coutand CLA 2012-04-20 05:25:02 EDT 
Created attachment 214297 [details]
Proposed patch

Here is a proposed patch for the bug.
Comment 2 Manuel Coutand CLA 2012-04-20 05:51:18 EDT 
Created attachment 214299 [details]
Proposed patch v2

Here is an updated version of the patch (removed some duplicate code).
Comment 3 Eugene Tarassov CLA 2012-04-20 14:23:32 EDT 
Committed the patch.
Thanks!
Comment 4 Martin Oberhuber CLA 2013-05-24 17:33:03 EDT 
Comment on attachment 214299 [details]
Proposed patch v2

iplog- since git has the author:

http://git.eclipse.org/c/tcf/org.eclipse.tcf.agent.git/commit/?id=fc3a574de4f70e377c704fa4d33b47157a355324