Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 377226 - [commands] scoped keybindings
Summary: [commands] scoped keybindings
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 377222
  Show dependency tree
 
Reported: 2012-04-19 16:03 EDT by Susan McCourt CLA
Modified: 2012-05-21 15:30 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-04-19 16:03:40 EDT 
In views with multiple sectional commands, we need to scope the keybindings to that section.  In practice this means stopping the propagation at a specified part of the DOM.
Comment 1 Susan McCourt CLA 2012-05-21 15:30:38 EDT 
Added the notion of a DomElement scope to a CommandKeyBinding.  Clients can provide an element or DOM id to which the command should be scoped. If not specified, it scopes global (the old behavior).  

Fixed in http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=803e8c57f8155342fd130285792d3f62cb11ca6f

For example, you can now use the Del Key in the navigator or the favorites list, but only when the list itself has the focus.