Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 377123 - Upgrade Gerrit to 2.4.2 (was: 2.3)
Summary: Upgrade Gerrit to 2.4.2 (was: 2.3)
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Gerrit (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eclipse Webmaster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 380295 386146
  Show dependency tree
 
Reported: 2012-04-18 15:35 EDT by Matthias Sohn CLA
Modified: 2013-03-12 15:56 EDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Sohn CLA 2012-04-18 15:35:45 EDT
git.eclipse.org/r still runs Gerrit 2.2.2-rc1. Since 2.2.2.1 
and also 2.3 have been released I would suggest to upgrade to 
Gerrit 2.3 which can be downloaded here [1].

[1] http://code.google.com/p/gerrit/downloads/list
Comment 1 Denis Roy CLA 2012-04-19 16:46:01 EDT
Wow, some folks have been busy.  Looks like a straightforward upgrade, I'll see what I can do.
Comment 2 Denis Roy CLA 2012-04-19 16:48:14 EDT
^^ that was a reference to the (rather packed) release notes:

http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-2.3.html
Comment 3 Matthias Sohn CLA 2012-04-26 02:45:47 EDT
yeah, 2.3 was cooking for quite a while hence it's bringing a ton of new features. Note, that also the first release candidate for 2.4 is already available [1]. Compared to the past release schedule the Gerrit project plans to do releases more frequently in the future, i.e. you may expect a new release every few months.

[1] http://groups.google.com/group/repo-discuss/browse_thread/thread/6d04c794fd191cd5/b805f981c07aac4d?lnk=gst&q=2.4rc0#b805f981c07aac4d
Comment 4 Denis Roy CLA 2012-04-26 09:51:33 EDT
I've run the upgrade, which was flawless.  But when I log in, the list of projects is gone...
Comment 5 Denis Roy CLA 2012-04-26 10:15:10 EDT
Looks like it's not following symlinks anymore.  All our projects are either symlinks to directories containing .git repos, or directories with symlinks to git repos.
Comment 6 Denis Roy CLA 2012-04-26 13:22:48 EDT
I upgraded, then backed out because of bug https://code.google.com/p/gerrit/issues/detail?id=1353
Comment 7 Steffen Pingel CLA 2012-07-04 11:29:08 EDT
Looks the bug has been fixed in Gerrit 2.4 which also adds an awesome Rebase button. I have take the liberty to update the summary accordingly. Would be great if a Gerrit update could be considered as part of Summer maintenance!
Comment 8 Denis Roy CLA 2012-07-04 15:07:45 EDT
Shouldn't be a problem.  I've backed everything up, and I'll give it a quick whirl tomorrow.
Comment 9 Denis Roy CLA 2012-07-05 08:44:27 EDT
I ran the upgrade, everything went smoothly, but now I can't seem to access any of the changes.  Clicking on an ID, I see the yellow "Working..." message appear and disappear, but nothing happens  :-(
Comment 10 Denis Roy CLA 2012-07-05 08:45:42 EDT
Firefox' error console shows this when I click something:

Error: uncaught exception: Class$GYb: One or more exceptions caught, see full set in UmbrellaException#getCauses
Comment 11 Denis Roy CLA 2012-07-05 09:06:32 EDT
*sigh*

I've reverted back to 2.2.2
Comment 12 Matthias Sohn CLA 2012-07-05 09:42:48 EDT
Did you see any errors in the error_log ?
Comment 13 Denis Roy CLA 2012-07-05 09:49:21 EDT
Nothing is generated in the error_log.

I've set up a 2.2.2 sandbox and got it working, then I upgraded the sandbox to 2.4.2.  It still behaves the same way (ie, clicking a change does nothing.

https://git.eclipse.org/sandbox/
Comment 14 Matthias Sohn CLA 2012-07-06 04:19:24 EDT
Could we get debug access to the sandbox instance ? Then we could help
debugging the problem from over here.
Comment 15 Denis Roy CLA 2012-07-06 08:44:06 EDT
The sandbox is alongside the production instance, but on a different port.  What kind of debugging would you do?  I appreciate the help, but at some point being self-sufficient would be nice.
Comment 16 Sasa Zivkov CLA 2012-07-09 11:20:11 EDT
The same (or similar) issue was discussed on gerrit discussion group:
https://groups.google.com/d/topic/repo-discuss/0eFLM6ytZyw/discussion

Could you try removing the [gitweb] section in gerrit.config on the sandbox instance and restart it
to verify if this workaround helps. If this solves the issue then please provide the [gitweb] section
here for further analysis.

It is not a solution to remove the [gitweb] section but we first need to be sure that this is causing the issue.
Comment 17 Denis Roy CLA 2012-07-09 11:23:10 EDT
Indeed, removing the gitweb section makes the sandbox usable:

#[gitweb]
#  url = http://git.eclipse.org/c/
#  type = custom
#  revision = ${project}.git/commit/${commit}
#  project = ${project}.git
#  branch = ${project}.git/commit/?h=${branch}
Comment 18 Matthias Sohn CLA 2012-10-17 09:59:02 EDT
Gerrit 2.5rc1 was just published [1], could you give it a try and update
the sandbox instance so that we can see if this fixes the problem which
occurred with 2.4 ?

[1] https://groups.google.com/forum/?fromgroups=#!topic/repo-discuss/fiv6-LW1mAM
Comment 19 Denis Roy CLA 2012-11-06 16:49:32 EST
I've upgraded the sandbox and re-enabled the [gitweb] section that I had removed in comment 17.

It still doesn't seem to work.  Commenting-out the [gitweb] section and restarting Gerrit works.
Comment 20 Denis Roy CLA 2012-11-08 13:34:53 EST
I've upgraded to Gerrit 2.5 (release, not the RC).
Comment 21 Edwin Kempin CLA 2012-11-08 13:52:54 EST
This GitWeb configuration looks like incomplete to me.
If you specify 'revision', 'project' and 'branch', you also need to set
the 'filehistory' parameter. Can you try to set it? E.g.
  filehistory = /?p=${project}.git;a=history;hb=${branch};f=${file}
Not sure, how exactly this must be set for your system, but it should
open the history for the file in a certain branch of the specified project.

Alternatively it is a valid GitWeb configuration to only specify type and url.

[1] https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#_a_id_gitweb_a_section_gitweb
Comment 22 Denis Roy CLA 2012-11-08 13:55:27 EST
I can try that; problem is, we're not using gitweb per se, but cGit, which has different semantics.
Comment 23 Denis Roy CLA 2012-11-21 09:18:50 EST
Gerrit 2.5 is broken also.

Gitweb links still cause issues, and pushing via https is broken:
http://code.google.com/p/gerrit/issues/detail?id=1408

It is unfortunate that we're burned by a second consecutive Gerrit upgrade.
Comment 24 Edwin Kempin CLA 2012-11-22 02:26:16 EST
Regarding the issue with the GitWeb links, have you actually tried setting the filehistory parameter?
Comment 25 Denis Roy CLA 2013-03-12 15:56:50 EDT
Closing, as we've been running 2.5.1 for a while now.