Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 377035 - compare with each other command not working in git log
Summary: compare with each other command not working in git log
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M2   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 341540
  Show dependency tree
 
Reported: 2012-04-17 17:23 EDT by Susan McCourt CLA
Modified: 2012-04-19 11:01 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-04-17 17:23:25 EDT 
- open git log on a file
- select two files
- type error in the console and the link in the "More" menu does not work

I found this while working on bug 341540.  For a moment I thought I'd broken it, but I just checked on orionhub.org and it's broken in M1.

See bug 341540 comment 8.  We need to change the implementation of this command so that it does not need to use a deferred.
Comment 1 Susan McCourt CLA 2012-04-17 17:27:08 EDT 
The error in the non-built Orion is
TypeError: secondArg is undefined  (undefined="null")gitCommands.js (line 755)

So hopefully we can fix this in a way that won't require a remote request anymore.
Comment 2 Szymon Brandys CLA 2012-04-19 11:01:42 EDT 
Compare works again. Fixed with 1fd4eaadc63ada353a81c2ba906484d8a21068d3.

(In reply to comment #1)
> So hopefully we can fix this in a way that won't require a remote request
> anymore.

The only way now to get URI for diff between two commits is to make an extra POST call. I raised a separate bug 377182 discussing another way to create the URI.