Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 376153 - Improve context queries syntax parsing
Summary: Improve context queries syntax parsing
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.0.0   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-05 05:28 EDT by Manuel Coutand CLA
Modified: 2013-06-05 05:42 EDT (History)
0 users

See Also:

Attachments
Proposed patch (5.13 KB, patch)
2012-04-05 05:30 EDT, Manuel Coutand CLA 		eugene: iplog-
Details | Diff
Proposed patch v2 (7.51 KB, patch)
2012-04-05 09:20 EDT, Manuel Coutand CLA 		mober.at+eclipse: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Coutand CLA 2012-04-05 05:28:34 EDT 
Build Identifier: 

The parsing of context queries doesn't returns errors when the syntax of a query is incorrect. This should be improved by setting errno and returning an error code when the parsing detects a syntax error.

Reproducible: Always
Comment 1 Manuel Coutand CLA 2012-04-05 05:30:10 EDT 
Created attachment 213620 [details]
Proposed patch

Here is a proposed patch to improve the parsing of context queries and report syntax errors.
Comment 2 Manuel Coutand CLA 2012-04-05 09:20:57 EDT 
Created attachment 213629 [details]
Proposed patch v2

Here is a second version of the proposed patch. This version has more explicit error messages (for later use by the clients).
Comment 3 Eugene Tarassov CLA 2012-04-05 14:42:14 EDT 
I have committed the patch.
Thanks!
Comment 4 Martin Oberhuber CLA 2013-05-24 17:29:26 EDT 
Comment on attachment 213629 [details]
Proposed patch v2

iplog- since git has the author:

http://git.eclipse.org/c/tcf/org.eclipse.tcf.agent.git/commit/?id=be86faea25c88368b8165f9517131f78de2e85a4