Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 376104 - operations API - client should be able to specify where status and messages go
Summary: operations API - client should be able to specify where status and messages go
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M1   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 371261
  Show dependency tree
 
Reported: 2012-04-04 12:36 EDT by Susan McCourt CLA
Modified: 2012-04-16 07:53 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-04-04 12:36:31 EDT
As part of bug 371261, we want clients to be able to run an operation without the messages automatically going to the status service.  See bug 371261 comment 10.

Szymon has agreed to be the client for this API in the repo page. 

Things to think about...
- where the progress/info messages go may be different than where warnings and errors go
- maybe there's a callback that supplies the text/status and the client decides.  
- we probably want some common helpers/default processing that still uses the status area if nothing else is specified.
Comment 1 Malgorzata Janczarska CLA 2012-04-10 12:06:09 EDT
I talked to Szymon and we agreed that displaying status message should not be managed by service. We should move displaying messages to caller's code and then find the best place for it. For commands it's usually still OK in the status area, but for most of the "Loading something..." messages we should move them to correct div.
By default the progress message will not be displayed anywhere. If operation takes too long and it's switched to task we still have a spinning Orion logo and details of operation on the operations list.
Comment 2 Malgorzata Janczarska CLA 2012-04-12 13:11:16 EDT
I refactored git client and moved all the messages to callers. In many places, especially where the message indicated that something is loading I moved it to the actual place where we are loading something.
Please note that for long running operations the details are still visible in the operations list and we have the "spinning balls" indication.
This still does not solve the problem of "bouncing" UI, because plenty of commands use the top status to indicate longer operations, like pushing. Also in many places other messages are placed there, git status adds plenty of messages there.