Community
Participate
Working Groups
buildJSPs.xml no longer compiles. This is most likely caused by the switch to Jetty 8. Steps to reproduce: 1. start new workspace 2. check out 'org.eclipse.help.webapp' from 'eclipse.platform.ua.git' ==> compile error shown in the console when building the project
Tom, you are probably more familiar with those changes. I assume we only need to update the classpath in this file.
FYI: I verified that it works when I start with 3.7.2 instead of latest 3.8 build.
See also bug 367102.
Tom, could you take a look?
Ping! Each time the workspace is rebuilt I run into this exception.
Ping ;-)
Created attachment 217499 [details] possible fix Here is a fixed up buildJSPs.xml. It seems to compile the JSPs fine during the build and I can successfully export the help.webapp from my workspace and the resulting bundle jar does contain the expected jsp .class files. But if I test this bundle out at runtime I still see the runtime recompiling the jsps. You can see this by finding the jsp .class files in the configuration/org.eclipse.osgi/bundles directory: ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/bookmarksToolbar_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/bookmarksView_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/content_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/contentToolbar_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/deferredView_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/help_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/helpToolbar_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/index_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/indexToolbar_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/indexView_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/livehelp_005fjs_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/nav_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/search_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/searchScoped_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/searchToolbar_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/searchView_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/tabs_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/tocToolbar_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/tocView_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/toolbar_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/view_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/advanced/views_jsp.class ./1093/data/jettywork/pid_2070971114/proxytemp/hc_20621054/org/apache/jsp/index_jsp.class Notice that at runtime it seems to compile the JSPs with the package name org.apache.jsp. The build.JSPs.xml specifies the package name to be org.eclipse.help.internal.webapp.jsp. If I remove the -p org.eclipse.help.internal.webapp.jsp option from the build script then the resulting bundle uses the org.apache.jsp package name, but at runtime I still see the jsp.class files get regenerated in the jettywork folder, so I have no ideas why the precompiled jsps are not getting found at runtime.
(In reply to comment #7) > Created attachment 217499 [details] [diff] > possible fix > > Here is a fixed up buildJSPs.xml. It seems to compile the JSPs fine during > the > build and I can successfully export the help.webapp from my workspace and the > resulting bundle jar does contain the expected jsp .class files. I verified that this works for me. I also verified that the generated classes (and package names) are the same as in previous Eclipse versions. Also, I see in previous versions that the org.apache.jsp.* were created, so this is not really a new problem but rather looks like bug 367102. See also bug 360465. I suggest we commit the fix and continue further investigations in bug 367102.
> I suggest we commit the fix and continue further investigations in bug > 367102. Ping! ;-)
(In reply to comment #9) > > I suggest we commit the fix and continue further investigations in bug > > 367102. > > Ping! ;-) Not sure if this is for me, but now realize it probably is. I agree that the fix should be released. I don't have commit access to eclipse.platform.ua.git. Dani could you commit the fix?
Fixed in 'R3_8_maintenance' with http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=22246e573250439137c9c7cfdf50b908d18ec431 Fixed in 'master' with http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=18ce83a47054a1eab40eb3626e8e720a292b5b3e
Verified in M20120815-1000 and M20120815-1200.
