Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 376034 - move native launchers code to rt.equinox.binaries git repository
Summary: move native launchers code to rt.equinox.binaries git repository
Status: CLOSED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Launcher (show other bugs)
Version: 3.8.0 Juno   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 370704
  Show dependency tree
 
Reported: 2012-04-03 23:42 EDT by Igor Fedorenko CLA
Modified: 2020-07-17 12:29 EDT (History)
10 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Fedorenko CLA 2012-04-03 23:42:10 EDT
As was discussed during CBI meetup at eclipsecon last week, it probably makes senses to move org.eclipse.equinox.launcher* bundles and org.eclipse.equinox.executable feature from rt.equinox.framework git repository to rt.equinox.binaries repository. Doing so will eliminate the need for all/most PDE/Build custom callbacks and will make native launchers build much easier to migrate to CBI.
Comment 1 Thomas Watson CLA 2012-04-04 08:32:25 EDT
I think the launchers use a similar approach as SWT for binaries and code.  Is there a similar bug opened for SWT?
Comment 2 Paul Webster CLA 2012-04-04 08:39:46 EDT
bug 372794

The approach to build SWT is much more complicated than the launchers, that's why this one is being looked at first.

PW
Comment 3 Andrea Ross CLA 2012-04-12 13:13:59 EDT
What do you think of this proposal? If this seems reasonable, Thanh, Igor, & I would be glad to help.
Comment 4 Andrea Ross CLA 2012-04-12 13:15:38 EDT
For clarity, please see Bug 370704 for the rationale for why we're asking for this.
Comment 5 Thomas Watson CLA 2012-04-12 16:03:42 EDT
(In reply to comment #3)
> What do you think of this proposal? If this seems reasonable, Thanh, Igor, & I
> would be glad to help.

This seems reasonable to me.  Silenio, Bogdan?

Is the best way forward to create a new test repository where you move the necessary stuff from rt.equinox.binaries and rt.equinox.framework?
Comment 6 Silenio Quarti CLA 2012-04-13 16:12:01 EDT
The reason SWT was split in two repos was because the binaries history is huge (over 200Mb) and most people (developers) just need the source code cloned (not the binaries). We build the SWT binaries at least once a week.

I believe the launcher was split into two repos to be consistent with SWT.

The launcher is not built as often, so the binary repo is much smaller. We just checked that rt.equinox.framework and rt.equinox.binaries together are around 70Mb. It is probably ok to merge them into one repo.  Note that we probably will not do the same to SWT.

Why do you want to move the source code into rt.equinox.binaries? Why not move the binaries back into rt.equinox.framework?
Comment 7 David Williams CLA 2012-04-13 17:18:36 EDT
I'm wondering how this fits into long term plans? 

If ultimate goal is for CBI to "build everything" for LTS, then what would source/binary repos look like then? I'd assume there would not be a binary repo at that point? right?  

So ... just suggesting the really long term impact be considered ... not that I know what the right thing to do is.
Comment 8 Krzysztof Daniel CLA 2012-09-19 07:47:07 EDT
There is one more consequence of staying with current approach - bug 386377.
Comment 9 Mykola Nikishov CLA 2019-02-02 05:25:14 EST
Should it be closed now?
Comment 10 Thomas Watson CLA 2019-02-02 11:53:14 EST
(In reply to Mykola Nikishov from comment #9)
> Should it be closed now?

I think the native source is still kept in the rt.equinox.framework repo for the launchers.  It would be nice if we didn't need a biniaries repo at all and the binaries were compiled at build time instead of a separate step and pushed to the binaries repo.
Comment 11 Alexander Kurtakov CLA 2020-07-17 12:29:06 EDT
Moving the launcher sources to binaries repo will not happen.