Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 375815 - org.eclipse.equinox.core.feature does not contain provider name
Summary: org.eclipse.equinox.core.feature does not contain provider name
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Server-Side (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: Juno M7   Edit
Assignee: equinox.server-side-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 04:27 EDT by Lukasz Koniecki CLA
Modified: 2012-04-02 10:10 EDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (918 bytes, patch)
2012-04-02 05:56 EDT, Lukasz Koniecki CLA 		tjwatson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lukasz Koniecki CLA 2012-04-02 04:27:44 EDT 
Build Identifier: 1.0.1.R37x_v20110907

feature.xml does not specify provider name.

See: http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/tree/features/org.eclipse.equinox.core.feature/feature.xml

There is:

<?xml version="1.0" encoding="UTF-8"?>
<feature
      id="org.eclipse.equinox.core.feature"
      label="%featureName"
      version="1.1.0.qualifier"
      license-feature="org.eclipse.license"
      license-feature-version="1.0.0.qualifier">

There should be:

<?xml version="1.0" encoding="UTF-8"?>
<feature
      id="org.eclipse.equinox.core.feature"
      label="%featureName"
      version="1.1.0.qualifier"
      provider-name="%providerName"
      license-feature="org.eclipse.license"
      license-feature-version="1.0.0.qualifier">

If I generate jnlp file for that feature I'm getting following definition:

<?xml version="1.0" encoding="UTF-8"?>
<jnlp spec="1.0+" codebase="$$codebase">
	<information>
		<title>Equinox Core Function</title>
		<offline-allowed/>
	</information>
	<security>
		<all-permissions/>
	</security>
	<component-desc/>
	<resources>
		<j2se version="1.5+" />
	</resources>
	<resources>
		<jar href="../plugins/org.eclipse.osgi_3.7.1.R37x_v20110808-1106.jar"/>
		<jar href="../plugins/org.eclipse.osgi.services_3.3.0.v20110513.jar"/>
		<jar href="../plugins/org.eclipse.equinox.common_3.6.0.v20110523.jar"/>
		<jar href="../plugins/org.eclipse.equinox.ds_1.3.1.R37x_v20110701.jar"/>
		<jar href="../plugins/org.eclipse.equinox.util_1.0.300.v20110502.jar"/>
		<jar href="../plugins/org.eclipse.core.jobs_3.5.100.v20110404.jar"/>
		<jar href="../plugins/org.eclipse.equinox.registry_3.5.101.R37x_v20110810-1611.jar"/>
		<jar href="../plugins/org.eclipse.equinox.simpleconfigurator_1.0.200.v20110502-1955.jar"/>
		<jar href="../plugins/org.eclipse.equinox.app_1.3.100.v20110321.jar"/>
	</resources>
</jnlp>

which is incorrect because it does not contain vendor element.

Reproducible: Always
Comment 1 Lukasz Koniecki CLA 2012-04-02 05:56:00 EDT 
Created attachment 213438 [details]
Proposed patch

Added provider-name="%providerName" to feature.xml